Re: roundup.cgi.actions.ExportCSVAction broken?

Hi all:

In message <[email protected]>,
Ralf Schlatterbeck writes:
>On Wed, Feb 06, 2019 at 03:53:50PM +0000, Tom Ekberg wrote:
>> I and members of my group have been using the ExportCSVNamesAction
>> code since March 2014. The original thought was to keep the original
>> version that outputs IDs and have another (ExportCSVNamesAction)
>> convert the IDs to names. I'm thinking of replacing the current
>> version. Does anyone see a need to keep the ExportCSVAction code that
>> outputs object IDs instead of names?
>OK
>I already have an implementation that uses names.
>
>I'll attach this to the other issue, maybe you want to integrate it.
>I've also had several requests over the years to show names not numbers.

I have a commit available that uses the patch in:

  https://issues.roundup-tracker.org/file1694/actions.py-patch.hgdiff

attached to 

  https://issues.roundup-tracker.org/issue2550833

ExportCSVAction now exports using names rather than id's.

I have created a new class ExportCSVWithIdAction that is the old
ExportCSVAction implementation. Note if a user has no permission to
View an item in the exported list, export will raise an assertion
rather than just skipping the item. This is verified in the test.

I modified and renamed all the existing testCSVExport* tests to work
with the new ExportCSVWithIdAction class. I duplicated the tests and
got them working with the new ExportCSVAction.

However it appears that we still have failing tests according to
travis ci.  I checked in the prior fixes to the code to support
OPTIONS and not hang when using verbs without payloads. Can anybody
work on getting the tests working again?

I don't want to check in my changes unless that is working in case I
broke something.

Also Joseph, are you going to commit Tom's python 3 patch for the wsgi
interface?

--
				-- rouilj
John Rouillard
===========================================================================
My employers don't acknowledge my existence much less my opinions.