Re: Remove Old Style Tracker and db/backend_name support (was: Is anybody using config.py rather ...)

* John P. Rouillard <[email protected]> [20201216 00:45]:
> It turns out that the support for old style trackers which had the files:
> 
>   config.py - replaced by config.ini in new style trackers
>   dbinit.py - replaced by schema.py in new style trackers (if present
>               the tracker is an old style tracker).
>   select_db.py - replaced by db/backend_name then RDBMS_BACKEND in config.ini
>   interfaces.py - still around
> 
> is still in the code base in instance.py. To go along with removal of
> support for config.py from configure.py, I propose removing the
> OldStyleTracker class from instance.py. This also removes another:
> 'import imp' from the code.
> 
> Also the obsolete db/backend_name file was replaced by RDBMS_BACKEND in
> config.ini in release 1.6. The code that supports it has a comment to
> delete support in revision 1.7 of roundup. That would be the minor rev
> after 1.6 which turned out to be rev 2.0. So I would like to nuke that
> support as well.
> 
> Does anybody have a problem with removing this dead code? (Hopefully
> with the removal of this old untested code I can get to 70% code
> coverage 8-).)

From above things I only require interfaces.py.
You write "still around", does this mean removing OldStyleTracker
will keep interfaces.py working as before?

If yes, go ahead and remove it.

If no, I need interfaces.py to patch/wrap roundup.mailgw.MailGW and
roundup.mailgw.parsedMessage, are there other ways to do this?

Regards,

Thomas

-- 
Thomas Arendsen Hein <[email protected]>
OpenPGP key: https://intevation.de/~thomas/thomas_pgp.asc (0xD45DE28FF3A2250C)
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner