Re: [Roundup-users] Remove Old Style Tracker and db/backend_name support (was: Is anybody using config.py rather ...)

Hi Thomas:

In message <[email protected]>,
Thomas Arendsen Hein writes:
>* John P. Rouillard <[email protected]> [20201216 00:45]:
>> It turns out that the support for old style trackers which had the files:
>> 
>>   config.py - replaced by config.ini in new style trackers
>>   dbinit.py - replaced by schema.py in new style trackers (if present
>>               the tracker is an old style tracker).
>>   select_db.py - replaced by db/backend_name then RDBMS_BACKEND in config.ini
>>   interfaces.py - still around
>> 
>> is still in the code base in instance.py. To go along with removal of
>> support for config.py from configure.py, I propose removing the
>> OldStyleTracker class from instance.py. This also removes another:
>> 'import imp' from the code.
>> 
>> [...]
>> Does anybody have a problem with removing this dead code? (Hopefully
>> with the removal of this old untested code I can get to 70% code
>> coverage 8-).)
>
>>From above things I only require interfaces.py.
>You write "still around", does this mean removing OldStyleTracker
>will keep interfaces.py working as before?

Sorry for not being clear. You are correct. The interfaces.py file is
suported by the new style tracker which will be the only style
supported going forward.

>If yes, go ahead and remove it.
>
>If no, I need interfaces.py to patch/wrap roundup.mailgw.MailGW and
>roundup.mailgw.parsedMessage, are there other ways to do this?

Interfaces.py is the correct documented way to do this.

Have a great weekend.

--
				-- rouilj
John Rouillard
===========================================================================
My employers don't acknowledge my existence much less my opinions.