Re: Re: [Bx-bugs] [Bug 899] doctypes

On 30.1.2006 12:20 Uhr, qMax wrote:
> Monday, January 30, 2006, 4:13:16 PM, Christian Stocker wrote:
> 
> 
> CS> On 30.1.2006 10:54 Uhr, qMax wrote:
> 
>>>This looks very interesting, since it adds scalability,
>>>and cleans up interfaces.
>>>If i get right, this could generalize all of
>>>collection::getPipelineNameByRequest()
>>>collection::getPipelineNameById()
>>>collection::getStylesheetNameByRequest()
>>>collection::getFiltersByRequest()
>>>plugin::getPipelineName()
>>>plugin::getStylesheetNameById()
>>>into just 2 methods of bx_plugin and bx_collection.
> 
> 
> CS> Didn't think about that, but you're basically right
> 
> CS> it still needs 2 methods
> CS> collection::getPipelineParametersById()
> CS> and
> CS> collection::getPipelineParametersByRequest()
> 
> CS> since the parameters are differernt.
> 
> There're
> getPluginMapById()/getPluginMapByRequest()
> + bx_plugin::getIdByRequest()
> Can't they help here ?

Look at the actual code of those 2 methods, they call the same method in
the end


public function getPipelineNameById($id) {
  return $this->getPipelineNameByPlugin( $this->getPluginMapById($id));
}


public function getPipelineNameByRequest($filename, $ext) {
  return $this->getPipelineNameByPlugin(
$this->getFirstPluginMapByRequest($filename,$ext));
}

I don't see the sense in merging them together (in
getPipelineParameters* of course instead of getPipelineName*)

chregu

> 
> 
> CS> chregu
> 
> 
>>>Sunday, January 29, 2006, 6:38:07 PM, Christian Stocker wrote:
>>>CS> Hi again
>>>CS> I had some idea, about the getStylesheetNameByRequest method.
>>>CS> Why not add another method like $collection->>getPipelineParametersByRequest($filename,$ext)
>>>CS> and the plugins can return a whole array of pipeline parameters, the
>>>CS> xmldoc would then
>>>CS> return array("stylesheet" => "mystylesheet.xsl");
>>>CS> and the bxcms action puts them into the pipeline.
>>>CS> This would make it more flexible to add any parameter to the pipeline
>>>CS> and not just one called "stylesheet".
>>>CS> chregu
> 
> 
> 
> 
> 
> 

-- 
christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 44 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71
http://www.bitflux.ch | [email protected] |  GPG 0x5CE1DECB
-- 
bitflux-cms mailing list
[email protected]
http://lists.bitflux.ch/cgi-bin/listinfo/bitflux-cms