Re[2]: Re: [Bx-bugs] [Bug 899] doctypes

Monday, January 30, 2006, 6:03:55 PM, Christian Stocker wrote:


CS> On 30.1.2006 12:20 Uhr, qMax wrote:
>> Monday, January 30, 2006, 4:13:16 PM, Christian Stocker wrote:
>> 
>> 
>> CS> On 30.1.2006 10:54 Uhr, qMax wrote:
>> 
>>>>This looks very interesting, since it adds scalability,
>>>>and cleans up interfaces.
>>>>If i get right, this could generalize all of
>>>>collection::getPipelineNameByRequest()
>>>>collection::getPipelineNameById()
>>>>collection::getStylesheetNameByRequest()
>>>>collection::getFiltersByRequest()
>>>>plugin::getPipelineName()
>>>>plugin::getStylesheetNameById()
>>>>into just 2 methods of bx_plugin and bx_collection.
>> 
>> 
>> CS> Didn't think about that, but you're basically right
>> 
>> CS> it still needs 2 methods
>> CS> collection::getPipelineParametersById()
>> CS> and
>> CS> collection::getPipelineParametersByRequest()
>> 
>> CS> since the parameters are differernt.
>> 
>> There're
>> getPluginMapById()/getPluginMapByRequest()
>> + bx_plugin::getIdByRequest()
>> Can't they help here ?

CS> Look at the actual code of those 2 methods, they call the same method in
CS> the end


CS> public function getPipelineNameById($id) {
CS>   return $this->getPipelineNameByPlugin( $this->getPluginMapById($id));
CS> }


CS> public function getPipelineNameByRequest($filename, $ext) {
CS>   return $this->getPipelineNameByPlugin(
$this->>getFirstPluginMapByRequest($filename,$ext));
CS> }

CS> I don't see the sense in merging them together (in
CS> getPipelineParameters* of course instead of getPipelineName*)

Yep, i already see that i've posted crap. :)

-- 
 qMax

-- 
bitflux-cms mailing list
[email protected]
http://lists.bitflux.ch/cgi-bin/listinfo/bitflux-cms