Re: doctypes

On 27.2.2006 14:24 Uhr, qMax wrote:
> I have redesigned xmldoc plugin abit
> and added example for simplified docbook format (yet w/out images and
> conversations).
> My (working) working copy is trunk(6556)+webroot(bug#903)+pipeline poperties(bug#901)
> xmldoc depends on #901 for 'stylesheet' pipeline parameter.

Ok, I committed those 2 patches (and clicked through a little bit). 
Looks ok to me (+ many thanks).

One wish. Could you please (in the future, I let it through for now) use 
4 spaces as "tab" instead of \t? Otherwise we have an ugly mish-mash. We 
don't have many coding-guidelines, but this one should be followed. In 
general, we follow the PEAR Coding Guidelines 
<http://pear.php.net/manual/en/standards.php>, but not very religiously, 
it's just more a reference, than a hard rule (except the 4spaces thing :) )

To all: qMax patch did change quite some deep internal things. In short, 
it replaces:

collection::getPipelineNameByPlugin
collection::getPipelineNameById
collection::getPipelineNameByRequest
collection::getStylesheetNameByRequest
collection::getFiltersByRequest

with:

collection::getPipelineParametersByRequest

which should make it a little bit easier in the future to put more 
parameters into the pipeline.

Please test your plugins/etc, if they still work :) But simple plugins 
didn't need those methods anyway, looking through the patch, it's mainly 
editors which have to change their  getPipelineName method:

-    public function getPipelineName() {
-        return "formedit";
+    public function getPipelineParametersById($path, $id) {
+        return array('pipelineName'=>'formedit');

and admin-plugins, which returned something in getStylesheetNameById.

If you have any questions about that (don't know how to fix your 
plugin), just ask here.

BTW, beni is currently reimplementing the comment code of the blog 
plugin (no more filter...), after that is done and some testing, we plan 
to release 1.4. Enough has changed (even no groundbreaking new features) 
to do that :)

chregu



-- 
christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 44 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71
http://www.bitflux.ch | [email protected] |  GPG 0x5CE1DECB
-- 
bitflux-cms mailing list
[email protected]
http://lists.bitflux.ch/cgi-bin/listinfo/bitflux-cms