[TikiWiki-commits] [Git][tikiwiki/tiki][master] [FIX] trackers: item deletion
"Jonny Bradley \(@jonnybradley\) via TikiWiki-cvs" <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.cvs |
|---|---|
| Message-ID | <6a314b2356da4_3819648c568e@gitlab-sidekiq-low-urgency-cpu-bound-v2-7d87cb8569-x566x.mail> |
Jonny Bradley pushed to branch master at Tiki Wiki CMS Groupware / Tiki
Commits:
3b478d6f by Jonny Bradley at 2026-06-16T12:55:48+00:00
[FIX] trackers: item deletion
---
* [FIX] trackers: item deletion: Fix removing the item from the search index (following regression in !9396 - just saying `index_handled` doesn't make it true)
* [FIX] trackers: item deletion: Don't show related items need replacing because `findUncascadedDeletes` always returns an array `['itemIds', 'fieldIds']` so count is always 2
See merge request tikiwiki/tiki!10534
- - - - -
2 changed files:
- lib/core/Services/Tracker/Controller.php
- lib/trackers/trackerlib.php
Changes:
=====================================
lib/core/Services/Tracker/Controller.php
=====================================
@@ -1983,7 +1983,7 @@ class Services_Tracker_Controller
}
$uncascaded = $trklib->findUncascadedDeletes($itemId, $trackerId);
- $affectedCount += count($uncascaded);
+ $affectedCount += count($uncascaded['itemIds']);
if ($_SERVER['REQUEST_METHOD'] == 'POST' || $_SERVER['REQUEST_METHOD'] == 'DELETE') {
$this->utilities->removeItemAndReferences($definition, $itemObject, $uncascaded, $input->replacement->int() ?: '');
=====================================
lib/trackers/trackerlib.php
=====================================
@@ -3298,7 +3298,6 @@ class TrackerLib extends TikiLib
'trackerId' => $trackerId,
'user' => $GLOBALS['user'],
'values' => $itemInfo,
- 'index_handled' => true,
'action' => 'delete',
]
);
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/3b478d6f666703b3371ae4d5075a52af9f217fdf
--
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/3b478d6f666703b3371ae4d5075a52af9f217fdf
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs