[TikiWiki-commits] [Git][tikiwiki/tiki][30.x] [FIX] trackers: item deletion

Jonny Bradley pushed to branch 30.x at Tiki Wiki CMS Groupware / Tiki


Commits:
ef2df28f by Jonny Bradley at 2026-06-16T13:32:56+00:00
[FIX] trackers: item deletion
---
* [FIX] trackers: item deletion: Fix removing the item from the search index (following regression in !9396 - just saying `index_handled` doesn't make it true)

* [FIX] trackers: item deletion: Don't show related items need replacing because `findUncascadedDeletes` always returns an array `['itemIds', 'fieldIds']` so count is always 2

See merge request tikiwiki/tiki!10534


(cherry picked from commit 3b478d6f666703b3371ae4d5075a52af9f217fdf)

13ad45a7 [FIX] trackers: item deletion: Don't show related items need replacing because...
3d9e1218 [FIX] trackers: item deletion: Fix removing the item from the search index...

Co-authored-by: Jonny Bradley <[email protected]>
- - - - -


2 changed files:

- lib/core/Services/Tracker/Controller.php
- lib/trackers/trackerlib.php


Changes:

=====================================
lib/core/Services/Tracker/Controller.php
=====================================
@@ -1975,7 +1975,7 @@ class Services_Tracker_Controller
             }
 
             $uncascaded = $trklib->findUncascadedDeletes($itemId, $trackerId);
-            $affectedCount += count($uncascaded);
+            $affectedCount += count($uncascaded['itemIds']);
 
             if ($_SERVER['REQUEST_METHOD'] == 'POST' || $_SERVER['REQUEST_METHOD'] == 'DELETE') {
                 $this->utilities->removeItemAndReferences($definition, $itemObject, $uncascaded, $input->replacement->int() ?: '');


=====================================
lib/trackers/trackerlib.php
=====================================
@@ -3267,7 +3267,6 @@ class TrackerLib extends TikiLib
                 'trackerId' => $trackerId,
                 'user' => $GLOBALS['user'],
                 'values' => $itemInfo,
-                'index_handled' => true,
                 'action' => 'delete',
             ]
         );



View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/ef2df28fcf8811e655b26650c3d4b47c0e1274e2

-- 
View it on GitLab: https://gitlab.com/tikiwiki/tiki/-/commit/ef2df28fcf8811e655b26650c3d4b47c0e1274e2
You're receiving this email because of your account on gitlab.com. Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
TikiWiki-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs