Re: [Tiki-devel] Top social network icons on the top page of t.o (community)
Bsfez Tiki via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
In the meantime merge request for master: https://gitlab.com/tikiwiki/tiki/-/merge_requests/702 <https://gitlab.com/tikiwiki/tiki/-/merge_requests/702> Be cherry-picked to 22 once approved. B > On 11 Feb 2021, at 13:36 , Bsfez Tiki via TikiWiki-devel <[email protected]> wrote: > >> Did you make that MR on 22.x? Everything needs to start on trunk/master now since 22.1 (see https://dev.tiki.org/Where-to-commit <https://dev.tiki.org/Where-to-commit>) > > Thanks for the headup, this merge request was made for Tiki22, but there is something you may help to clarify. ;-) > > On PHPstorm I have a Tiki. > I understand that I have to check out master then to create a new fix branch. > > So this branch fix branch will be based on master. > > Correct ? > > <Screen Shot 2021-02-11 at 13.33.19 .png> > > > > > >> On 11 Feb 2021, at 12:21 , Jonny Bradley via TikiWiki-devel <[email protected] <mailto:[email protected]>> wrote: >> >> Hi Bernard >> >> Looks like the CI pipelines are still running on that merge request, but it looks (probably) ok to me. >> >> Did you make that MR on 22.x? Everything needs to start on trunk/master now since 22.1 (see https://dev.tiki.org/Where-to-commit <https://dev.tiki.org/Where-to-commit>) >> >> Did you see this little snippet on doc? >> >> http://doc.tiki.org/PluginList---Hacks-and-Fun#Set_the_Browser_Page_Title <http://doc.tiki.org/PluginList---Hacks-and-Fun#Set_the_Browser_Page_Title> >> >> I think the same trick will work with pagedescription="y", maybe give that a try? >> >> jb >> >> >> >> >> >>> On 11 Feb 2021, at 10:06, Bsfez Tiki via TikiWiki-devel <[email protected] <mailto:[email protected]>> wrote: >>> >>> Hello, >>> >>> Thanks to who added those top icon they look very good. >>> >>> However usage is not successful… 😞 >>> I review the metatags and fix some errors and logic (https://gitlab.com/tikiwiki/tiki/-/merge_requests/701/diffs <https://gitlab.com/tikiwiki/tiki/-/merge_requests/701/diffs>) >>> >>> The request were not merged and t.o was not updated but still the sharing posts from t.o are not very good in the case of a Wiki page. (see below) >>> >>> Wouldn’t be better if we enable using the page description (if exist) instead of the description metatag (always the same). >>> Do you agree ? >>> >>> B >>> >>> >>> <twitter.jpg> >>> >>> <facebook.jpg> >>> _______________________________________________ >>> TikiWiki-devel mailing list >>> [email protected] <mailto:[email protected]> >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >> >> >> >> _______________________________________________ >> TikiWiki-devel mailing list >> [email protected] <mailto:[email protected]> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > _______________________________________________ > TikiWiki-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel _______________________________________________ TikiWiki-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel