Re: [Tiki-devel] Long and complex string in translation files
Jonny Bradley via TikiWiki-devel <[email protected]>
| Newsgroups | gmane.comp.cms.tiki.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Brendan Yes, loading a file that works is ok, i was trying to test loading a file that fails to see that particular error message - like a 47MB file when the max upload size was 8MB, and for some reason nothing happens... The tr string is fixed now, so no need to worry on that one (hopefully ;) Thanks jonny > On 16 Feb 2021, at 16:22, Brendan Ferguson <[email protected]> wrote: > > I just tested the feature by uploading a file. Seems to work ok for me. > > I can also look into the strange string as well. Close the TR properly. > > Brendan > > > >> On Feb 16, 2021, at 7:28 AM, Jonny Bradley via TikiWiki-devel <[email protected]> wrote: >> >> Hi Bernard and all >> >> Thanks, i think a better fix for that would be to make the $_FILES['passwordlist']['error'] the "%0" argument for the tr function, like: >> >> - Feedback::error(tr('File Upload Error: ' . $_FILES['passwordlist']['error'])); >> + Feedback::error(tr('File Upload Error: %0', $_FILES['passwordlist']['error'])); >> >> will do it... wonder how too test it though... sadly, it seems the whole feature is broken, sorry i don't have time to fix it (tried to upload a 47MB file with 8MB max and the $_POST request is just empty, odd). >> >> Anyway, will do the get strings thing and start backporting... >> >> Done, thanks B >> >> jb >> >> >> >>> On 16 Feb 2021, at 07:25, Bsfez Tiki via TikiWiki-devel <[email protected]> wrote: >>> >>> Hello, >>> >>> Checking translations on a Tiki 22 I found this string: >>> // "File Upload Error: ' . \$_FILES['passwordlist']['error']));\n\t} else { // if file has been uploaded, and there are no errors, then index the file in the database.\n\t\t\$blackL->deletePassIndex();\n\t\t\$blackL->createPassIndex();\n\t\t\$blackL->loadPassIndex(\$_FILES['passwordlist']['tmp_name'], \$_POST['loaddata']);\n\t\tFeedback::success(tra('Uploaded file has been populated into database and indexed. Ready to generate password lists" => "File Upload Error: ' . \$_FILES['passwordlist']['error']));\n\t} else { // if file has been uploaded, and there are no errors, then index the file in the database.\n\t\t\$blackL->deletePassIndex();\n\t\t\$blackL->createPassIndex();\n\t\t\$blackL->loadPassIndex(\$_FILES['passwordlist']['tmp_name'], \$_POST['loaddata']);\n\t\tFeedback::success(tra('Uploaded file has been populated into database and indexed. Ready to generate password lists", >>> While PHPstorm search couldn’t find the source directly it seems it comes from: >>> >>> admin/include_login.php line 84 >>> Feedback::error(tr('File Upload Error: ' . $_FILES['passwordlist']['error'])); >>> >>> The tr tags is not closed properly. Is this the correct way to fix it ? >>> Feedback::error(tr('File Upload Error: ') . $_FILES['passwordlist']['error']); >>> >>> May it is also in 21.3 (should be an update today) ? >>> >>> Thanks >>> B >>> _______________________________________________ >>> TikiWiki-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >> >> >> >> _______________________________________________ >> TikiWiki-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > _______________________________________________ > TikiWiki-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel _______________________________________________ TikiWiki-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel