[Tiki-devel] phpcs code sniffing

Jonny Bradley via TikiWiki-devel <[email protected]>
Newsgroups gmane.comp.cms.tiki.devel
Message-ID <[email protected]>
Hi all, this is for Benoit mostly i think (hope you're here ;)

I saw a week or two ago you did some refactoring on the tracker field class names (thanks!) and it involved this file doc/devtools/codesniffer/standards/TikiIgnore/ignore_list.json which i was unaware of.

In my long running calendar revamp branch https://gitlab.com/jonnybradley/tiki/-/tree/calendar-revamp-2 it seems i had broken quite a few new tests, and the only way i found to fix them was by regenerating that file, in this commit:

https://gitlab.com/tikiwiki/tiki/-/merge_requests/2249/diffs?commit_id=7964abf7cebb47ed540430790e42bf4793870f1b

There are a lot of changes in the diff, so hard to track visually, but will this have undone anything you or anyone else did involving it?

TIA

jonny
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.