omniORB: reserved identifier violation

Markus Elfring via omniORB-dev <[email protected]> Sun, 29 Oct 2023 15:35:33 +0100

Newsgroups	gmane.comp.corba.omniorb.devel
Message-ID	<[email protected]>

Hello,

I would like to point out that identifiers like the following do not fit to
the expected naming convention of the C++ language standard.
* __CORBA_H__
  https://sourceforge.net/p/omniorb/svn/6666/tree/branches/4_4/omniORB/include/omniORB4/CORBA.h#l29

* __omnithread_h_
  https://sourceforge.net/p/omniorb/svn/6666/tree/branches/4_4/omniORB/include/omnithread.h#l35

Would you like to adjust your selection for unique names?
https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

Regards,
Markus