Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders
Tom Lane <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
Pierre Ducroquet <[email protected]> writes: > Attached to this email is a patch with better comments regarding the > XLogSendLogical change. Hi, This patch entirely fails to apply for me (and for the cfbot too). It looks like (a) it's missing a final newline and (b) all the tabs have been mangled into spaces, and not correctly mangled either. I could probably reconstruct a workable patch if I had to, but it seems likely that it'd be easier for you to resend it with a little more care about attaching an unmodified attachment. As for the question of back-patching, it seems to me that it'd likely be reasonable to put this into v12, but probably not further back. There will be no interest in back-patching commit cfdf4dc4f, and it seems like the argument for this patch is relatively weak without that. regards, tom lane