Re: proposal: minscale, rtrim, btrim functions for numeric

po 6. 1. 2020 v 18:22 odesílatel Tom Lane <[email protected]> napsal:

> Pavel Stehule <[email protected]> writes:
> > út 10. 12. 2019 v 13:56 odesílatel Karl O. Pinc <[email protected]> napsal:
> >> I'm marking it ready for a committer.
>
> > Thank you for review
>
> Pushed with minor adjustments.  Notably, I didn't like having
> get_min_scale() depend on its callers having stripped trailing zeroes
> to avoid getting into a tight infinite loop.  That's just trouble
> waiting to happen, especially since non-stripped numerics are seldom
> seen in practice (ones coming into the SQL-level functions should
> never look like that, ie the strip_var calls you had are almost
> certainly dead code).  If we did have a code path where the situation
> could occur, and somebody forgot the strip_var call, the omission
> could easily escape notice.  So I got rid of the strip_var calls and
> made get_min_scale() defend itself against the case.  It's hardly
> any more code, and it should be a shade faster than strip_var anyway.
>

Thank you very much

Maybe this issue was part of ToDo list

Pavel


>                         regards, tom lane
>