Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi,

On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad <[email protected]> wrote:

> Hi,
>
> On Tue, Aug 6, 2019, 6:01 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Seems to work well :-). A few comments:
>>
>> - Should we have an icon by the non-generated queries (the lightning
>> flash) and the COMMITs etc (the commit/rollback icon as appropriate) as
>> well? I think just having the icon for generated queries looks a little odd.
>>
>
> I am sorry I don't quite understand. Do you mean having an icon to
> show/hide user queries as well? I believe a checkbox is more appropriate
> anyway, maybe placed right above the history entries. I am going to need a
> design of the checkbox or styling guidlines though.
>

Another idea that came to my mind is to use a dropdown menu checkbox just
next to the save data icon. Similar to auto-commot and auto-rollback
checkboxs in the dropdown menu next to the execute (flash) icon. What do
you think is better? This, or a checkbox right above the history entries?