Re: [pgAdmin][RM4554] RE-SQL for trigger functions
Aditya Toshniwal <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CAM9w-_nEhmMNdbCB0KVdXXznT24NcMHinULrdM3-nT+FehKpQQ@mail.gmail.com> |
Hi Hackers, I've improved the output messages to add more detail for trigger functions RE-SQL test cases. Attached is the patch. On Tue, Aug 6, 2019 at 6:58 PM Dave Page <[email protected]> wrote: > Thanks, applied. > > On Tue, Aug 6, 2019 at 1:57 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> Attached is the patch to add RE-SQL test cases for trigger functions. >> I've also fixed few spacing issues here and there in SQLs generated. >> >> This patch also includes fix for >> https://redmine.postgresql.org/issues/4565 >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
RM4554.messages.patch
(application/octet-stream, 1.6 KB)
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/tests/pg/default/test_trigger_functions.json b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/tests/pg/default/test_trigger_functions.json
index 61612704..11bef3d1 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/tests/pg/default/test_trigger_functions.json
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/tests/pg/default/test_trigger_functions.json
@@ -31,7 +31,7 @@
"expected_sql_file": "alter_ptrig_comment.sql"
}, {
"type": "alter",
- "name": "Alter trigger function Set 1",
+ "name": "Alter trigger function Set 1 - Strict, Leakproof, Security of definer, Volatility",
"endpoint": "NODE-trigger_function.obj_id",
"sql_endpoint": "NODE-trigger_function.sql_id",
"data": {
@@ -43,7 +43,7 @@
"expected_sql_file": "alter_ptrig_set_1.sql"
}, {
"type": "alter",
- "name": "Alter trigger function Set 2",
+ "name": "Alter trigger function Set 2 - Cost, Volatility, Add Param",
"endpoint": "NODE-trigger_function.obj_id",
"sql_endpoint": "NODE-trigger_function.sql_id",
"data": {
@@ -59,7 +59,7 @@
"expected_sql_file": "alter_ptrig_set_2.sql"
}, {
"type": "alter",
- "name": "Alter trigger function Set 3",
+ "name": "Alter trigger function Set 3 - Add Param, Change Param",
"endpoint": "NODE-trigger_function.obj_id",
"sql_endpoint": "NODE-trigger_function.sql_id",
"data": {