[pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan

--00000000000081101e059a21a85c
Content-Type: multipart/alternative; boundary="00000000000081101b059a21a85a"

--00000000000081101b059a21a85a
Content-Type: text/plain; charset="UTF-8"

Hi,

PFA patch for adding aria-label to buttons used in graphical explain plan
section.

- Fixed another minor issue where we will only use dialog tab navigator
keyboard shortcuts only on visible tabs.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--00000000000081101b059a21a85a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_defa=
ult" style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">Hi,<br cl=
ear=3D"all"></div><div class=3D"gmail_default" style=3D"font-family:verdana=
,sans-serif;color:rgb(68,68,68)"><br></div><div class=3D"gmail_default" sty=
le=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">PFA patch for add=
ing aria-label to buttons used in graphical explain plan section.</div><div=
 class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(=
68,68,68)"><br></div><div class=3D"gmail_default" style=3D"font-family:verd=
ana,sans-serif;color:rgb(68,68,68)">- Fixed another minor issue where we wi=
ll only use=C2=A0dialog tab navigator keyboard shortcuts only on visible ta=
bs.</div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-ser=
if;color:rgb(68,68,68)"><br></div><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif;color:rgb(68,68,68)"><br></div><div><div dir=3D=
"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=
=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" face=3D"verdana, sans-serif=
" color=3D"#444444">--</font><div><font size=3D"2" face=3D"verdana, sans-se=
rif" color=3D"#444444">Regards,</font><div><font size=3D"2"><font face=3D"v=
erdana, sans-serif" color=3D"#444444">Murtuza Zabuawala<br>EnterpriseDB:=C2=
=A0<a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" target=3D"_b=
lank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<=
/font></font></div></div><div><font size=3D"2"><font face=3D"verdana, sans-=
serif" color=3D"#444444"><br></font></font></div></div></div></div></div></=
div></div></div></div></div></div></div></div></div></div></div></div></div=
></div>

--00000000000081101b059a21a85a--
--00000000000081101e059a21a85c
Content-Type: application/octet-stream; name="pgadmin4.diff"
Content-Disposition: attachment; filename="pgadmin4.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_k4dzax6s0>
X-Attachment-Id: f_k4dzax6s0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5q
cyBiL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5qcwppbmRleCAx
NGNhNzZhMTU4Li41OGQxMTJkZWY5IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL3N0YXRp
Yy9leHBsYWluL2pzL2V4cGxhaW4uanMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aWMvZXhw
bGFpbi9qcy9leHBsYWluLmpzCkBAIC0xMjgzLDcgKzEyODMsOCBAQCBkZWZpbmUoJ3BnYWRtaW4u
bWlzYy5leHBsYWluJywgWwogICAgICAgICB9KS5hcHBlbmRUbyhncmFwaGljYWxDb250YWluZXIp
LAogICAgICAgICB6b29tSW5CdG4gPSAkKCc8YnV0dG9uPjwvYnV0dG9uPicsIHsKICAgICAgICAg
ICBjbGFzczogJ2J0biBidG4tc2Vjb25kYXJ5IHBnLWV4cGxhaW4tem9vbS1idG4nLAotICAgICAg
ICAgIHRpdGxlOiAnWm9vbSBpbicsCisgICAgICAgICAgdGl0bGU6IGdldHRleHQoJ1pvb20gaW4n
KSwKKyAgICAgICAgICAnYXJpYS1sYWJlbCc6IGdldHRleHQoJ1pvb20gaW4nKSwKICAgICAgICAg
ICB0YWJpbmRleDogMCwKICAgICAgICAgfSkuYXBwZW5kVG8oem9vbUFyZWEpLmFwcGVuZCgKICAg
ICAgICAgICAkKCc8aT48L2k+JywgewpAQCAtMTI5MSw3ICsxMjkyLDggQEAgZGVmaW5lKCdwZ2Fk
bWluLm1pc2MuZXhwbGFpbicsIFsKICAgICAgICAgICB9KSksCiAgICAgICAgIHpvb21Ub05vcm1h
bCA9ICQoJzxidXR0b24+PC9idXR0b24+JywgewogICAgICAgICAgIGNsYXNzOiAnYnRuIGJ0bi1z
ZWNvbmRhcnkgcGctZXhwbGFpbi16b29tLWJ0bicsCi0gICAgICAgICAgdGl0bGU6ICdab29tIHRv
IG9yaWdpbmFsJywKKyAgICAgICAgICB0aXRsZTogZ2V0dGV4dCgnWm9vbSB0byBvcmlnaW5hbCcp
LAorICAgICAgICAgICdhcmlhLWxhYmVsJzogZ2V0dGV4dCgnWm9vbSB0byBvcmlnaW5hbCcpLAog
ICAgICAgICAgIHRhYmluZGV4OiAwLAogICAgICAgICB9KS5hcHBlbmRUbyh6b29tQXJlYSkuYXBw
ZW5kKAogICAgICAgICAgICQoJzxpPjwvaT4nLCB7CkBAIC0xMjk5LDcgKzEzMDEsOCBAQCBkZWZp
bmUoJ3BnYWRtaW4ubWlzYy5leHBsYWluJywgWwogICAgICAgICAgIH0pKSwKICAgICAgICAgem9v
bU91dEJ0biA9ICQoJzxidXR0b24+PC9idXR0b24+JywgewogICAgICAgICAgIGNsYXNzOiAnYnRu
IGJ0bi1zZWNvbmRhcnkgcGctZXhwbGFpbi16b29tLWJ0bicsCi0gICAgICAgICAgdGl0bGU6ICda
b29tIG91dCcsCisgICAgICAgICAgdGl0bGU6IGdldHRleHQoJ1pvb20gb3V0JyksCisgICAgICAg
ICAgJ2FyaWEtbGFiZWwnOiBnZXR0ZXh0KCdab29tIG91dCcpLAogICAgICAgICAgIHRhYmluZGV4
OiAwLAogICAgICAgICB9KS5hcHBlbmRUbyh6b29tQXJlYSkuYXBwZW5kKAogICAgICAgICAgICQo
JzxpPjwvaT4nLCB7CkBAIC0xMzEzLDcgKzEzMTYsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5l
eHBsYWluJywgWwogICAgICAgICBkb3dubG9hZEJ0biA9ICQoJzxidXR0b24+PC9idXR0b24+Jywg
ewogICAgICAgICAgIGlkOiAnYnRuLWV4cGxhaW4tZG93bmxvYWQnLAogICAgICAgICAgIGNsYXNz
OiAnYnRuIGJ0bi1zZWNvbmRhcnkgcGctZXhwbGFpbi1kb3dubG9hZC1idG4nLAotICAgICAgICAg
IHRpdGxlOiAnRG93bmxvYWQnLAorICAgICAgICAgIHRpdGxlOiBnZXR0ZXh0KCdEb3dubG9hZCcp
LAorICAgICAgICAgICdhcmlhLWxhYmVsJzogZ2V0dGV4dCgnRG93bmxvYWQnKSwKICAgICAgICAg
ICB0YWJpbmRleDogMCwKICAgICAgICAgICBkaXNhYmxlZDogZnVuY3Rpb24oKSB7CiAgICAgICAg
ICAgICB2YXIgY3VycmVudF9icm93c2VyID0gcGdBZG1pbi5Ccm93c2VyLmdldF9icm93c2VyKCk7
CkBAIC0xMzQxLDcgKzEzNDUsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5leHBsYWluJywgWwog
ICAgICAgJCgnPGJ1dHRvbj48L2J1dHRvbj4nLCB7CiAgICAgICAgIGlkOiAnYnRuLWV4cGxhaW4t
c3RhdHMnLAogICAgICAgICBjbGFzczogJ2J0biBidG4tc2Vjb25kYXJ5IHBnLWV4cGxhaW4tc3Rh
dHMtYnRuJywKLSAgICAgICAgdGl0bGU6ICdTdGF0aXN0aWNzJywKKyAgICAgICAgdGl0bGU6IGdl
dHRleHQoJ1N0YXRpc3RpY3MnKSwKKyAgICAgICAgJ2FyaWEtbGFiZWwnOiBnZXR0ZXh0KCdTdGF0
aXN0aWNzJyksCiAgICAgICAgIHRhYmluZGV4OiAwLAogICAgICAgfSkuYXBwZW5kVG8oc3RhdHNB
cmVhKS5hcHBlbmQoCiAgICAgICAgICQoJzxpPjwvaT4nLCB7CmRpZmYgLS1naXQgYS93ZWIvcGdh
ZG1pbi9zdGF0aWMvanMvZGlhbG9nX3RhYl9uYXZpZ2F0b3IuanMgYi93ZWIvcGdhZG1pbi9zdGF0
aWMvanMvZGlhbG9nX3RhYl9uYXZpZ2F0b3IuanMKaW5kZXggNTk0MzcxMTU5OC4uYjNmZmM5OTZm
NyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2RpYWxvZ190YWJfbmF2aWdhdG9y
LmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9kaWFsb2dfdGFiX25hdmlnYXRvci5qcwpA
QCAtMTksNyArMTksNyBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogCiAgICAgdGhpcy50
YWJTd2l0Y2hpbmcgPSBmYWxzZTsKIAotICAgIHRoaXMudGFicyA9IHRoaXMuZGlhbG9nQ29udGFp
bmVyLmZpbmQoJy5uYXYtdGFicycpOworICAgIHRoaXMudGFicyA9IHRoaXMuZGlhbG9nQ29udGFp
bmVyLmZpbmQoJy5uYXYtdGFiczp2aXNpYmxlJyk7CiAKICAgICBpZiAodGhpcy50YWJzLmxlbmd0
aCA+IDAgKSB7CiAgICAgICB0aGlzLnRhYnMgPSB0aGlzLnRhYnNbMF07CkBAIC0zNSw3ICszNSw3
IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAKICAgb25LZXlib2FyZEV2ZW50KGV2ZW50
LCBzaG9ydGN1dCkgewogICAgIHZhciBjdXJyZW50VGFiUGFuZSA9ICB0aGlzLmRpYWxvZ0NvbnRh
aW5lcgotICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2
ZTpmaXJzdCcpLAorICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5l
LmFjdGl2ZTpmaXJzdDp2aXNpYmxlJyksCiAgICAgICBjaGlsZFRhYkRhdGEgPSB0aGlzLmlzQWN0
aXZlUGFuZUhhc0NoaWxkVGFicyhjdXJyZW50VGFiUGFuZSk7CiAKICAgICBpZiAodGhpcy50YWJT
d2l0Y2hpbmcpIHsKQEAgLTU3LDEyICs1NywxMiBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3Ig
ewogICB9CiAKICAgaXNBY3RpdmVQYW5lSGFzQ2hpbGRUYWJzKGN1cnJlbnRUYWJQYW5lKSB7Ci0g
ICAgdmFyIGNoaWxkVGFiID0gY3VycmVudFRhYlBhbmUuZmluZCgnLm5hdi10YWJzOmZpcnN0Jyks
CisgICAgdmFyIGNoaWxkVGFiID0gY3VycmVudFRhYlBhbmUuZmluZCgnLm5hdi10YWJzOmZpcnN0
OnZpc2libGUnKSwKICAgICAgIGNoaWxkVGFiUGFuZTsKIAogICAgIGlmIChjaGlsZFRhYi5sZW5n
dGggPiAwKSB7CiAgICAgICBjaGlsZFRhYlBhbmUgPSBjdXJyZW50VGFiUGFuZQotICAgICAgICAu
ZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdCcpOworICAg
ICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdDp2
aXNpYmxlJyk7CiAKICAgICAgIHJldHVybiB7CiAgICAgICAgICdjaGlsZFRhYic6IGNoaWxkVGFi
LApAQCAtOTMsNyArOTMsNyBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogCiAgICAgICBu
ZXh0VGFiUGFuZSA9IHRhYl9wYW5lLnByZXYoKTsKICAgICAgIGlubmVyVGFiQ29udGFpbmVyID0g
bmV4dFRhYlBhbmUKLSAgICAgICAgLmZpbmQoJy50YWItY29udGVudDpmaXJzdCA+IC50YWItcGFu
ZS5hY3RpdmU6Zmlyc3QnKTsKKyAgICAgICAgLmZpbmQoJy50YWItY29udGVudDpmaXJzdCA+IC50
YWItcGFuZS5hY3RpdmU6Zmlyc3Q6dmlzaWJsZScpOwogCiAgICAgICBpZiAoaW5uZXJUYWJDb250
YWluZXIubGVuZ3RoID4gMCkgewogICAgICAgICBmaW5kQW5kU2V0Rm9jdXMoaW5uZXJUYWJDb250
YWluZXIpOwpAQCAtMTI0LDcgKzEyNCw3IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAK
ICAgICAgIG5leHRUYWJQYW5lID0gdGFiX3BhbmUubmV4dCgpOwogICAgICAgaW5uZXJUYWJDb250
YWluZXIgPSBuZXh0VGFiUGFuZQotICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4g
LnRhYi1wYW5lLmFjdGl2ZTpmaXJzdCcpOworICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZp
cnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdDp2aXNpYmxlJyk7CiAKICAgICAgIGlmIChpbm5l
clRhYkNvbnRhaW5lci5sZW5ndGggPiAwKSB7CiAgICAgICAgIGZpbmRBbmRTZXRGb2N1cyhpbm5l
clRhYkNvbnRhaW5lcik7Cg==
--00000000000081101e059a21a85c--