Re: [pgAdmin][RM5017] Use cheroot as default production server
Aditya Toshniwal <[email protected]> Fri, 20 Dec 2019 18:21:39 +0530
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CAM9w-_ny_icvP7SCqAQ9CdeOnRWaAeeX4esSYkP2dHCQcjtXNA@mail.gmail.com> |
--000000000000b0316d059a2225cc Content-Type: text/plain; charset="UTF-8" Hi Ashesh, I had tried with - https://newrelic.com/ API to check Flask app performance. To be honest, there was not a great difference in the performance. Per new relic, cheroot used slightly less CPU, with more RPM and, with less response time. Anyway, flask is still not recommended and cheroot looks a good option as it is pure python and supports almost all OS. On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi <[email protected]> wrote: > Have you seen any improvements in performance? > > On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, < > [email protected]> wrote: > >> Hi Hackers, >> >> Attached is the patch to use https://pypi.org/project/cheroot/ instead >> of current flask dev server. cheroot is a stable production ready server. >> Plus, flask dev server is not recommended for production. >> Code is changed to use cheroot only when DEBUG is False, otherwise you >> the default flask server. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --000000000000b0316d059a2225cc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,= sans-serif">Hi Ashesh,<br></div><div class=3D"gmail_default" style=3D"font-= family:verdana,sans-serif"><br></div><div class=3D"gmail_default" style=3D"= font-family:verdana,sans-serif">I had tried with -=C2=A0<a href=3D"https://= newrelic.com/" style=3D"font-family:Arial,Helvetica,sans-serif">https://new= relic.com/</a>=C2=A0API to check Flask app performance. To be=C2=A0honest, = there was not a great difference in the performance.=C2=A0</div><div class= =3D"gmail_default" style=3D"font-family:verdana,sans-serif">Per new relic, = cheroot used slightly less CPU, with more RPM and, with less response time.= </div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif"= >Anyway, flask is still not recommended=C2=A0and cheroot looks a good optio= n as it is pure python and supports almost all OS.</div></div><br><div clas= s=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Dec 20, 201= 9 at 1:34 PM Ashesh Vashi <<a href=3D"mailto:[email protected]= om">[email protected]</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"><div dir=3D"auto">Have you seen any improv= ements in performance?=C2=A0</div><br><div class=3D"gmail_quote"><div dir= =3D"ltr" class=3D"gmail_attr">On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, = <<a href=3D"mailto:[email protected]" target=3D"_blank">= [email protected]</a>> wrote:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_defau= lt" style=3D"font-family:verdana,sans-serif">Hi Hackers,</div><div class=3D= "gmail_default" style=3D"font-family:verdana,sans-serif"><br></div><div cla= ss=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Attached is t= he patch to use=C2=A0<a href=3D"https://pypi.org/project/cheroot/" style=3D= "font-family:Arial,Helvetica,sans-serif" rel=3D"noreferrer" target=3D"_blan= k">https://pypi.org/project/cheroot/</a>=C2=A0instead of current flask dev = server. cheroot is a stable production ready server. Plus, flask dev server= is not recommended for production.</div><div class=3D"gmail_default" style= =3D"font-family:verdana,sans-serif">Code is changed to use cheroot only whe= n DEBUG is False, otherwise=C2=A0you the default flask server.</div><div><b= r></div><div><div class=3D"gmail_default" style=3D"font-family:verdana,sans= -serif">Kindly review.</div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"l= tr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font= size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regar= ds,</font><div><span style=3D"background-color:rgb(255,255,255)"><font size= =3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</fon= t></span></div><div><font face=3D"verdana, sans-serif"><span style=3D"backg= round-color:rgb(255,255,255)"><font size=3D"2" color=3D"#000000">Sr. Softwa= re Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span style=3D"c= olor:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#38761d" face= =3D"verdana, sans-serif" size=3D"1">"Don't Complain about Heat, Pl= ant a TREE"</font></div></div></div></div></div></div></div></div></di= v></div> </blockquote></div> </blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"= class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div= dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" c= olor=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</font><di= v><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" color= =3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span></d= iv><div><font face=3D"verdana, sans-serif"><span style=3D"background-color:= rgb(255,255,255)"><font size=3D"2" color=3D"#000000">pgAdmin Hacker | Sr. S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span style= =3D"color:rgb(0,0,0)">Pune</span></font></div><div><font color=3D"#38761d" = face=3D"verdana, sans-serif" size=3D"1">"Don't Complain about Heat= , Plant a TREE"</font></div></div></div></div></div></div></div></div>= </div></div></div> --000000000000b0316d059a2225cc--