Re: [BUG] build trunk error

Thanks Keith.  My part is OK.

Best,
Hui

On Fri, May 13, 2011 at 08:37, Keith Seitz <[email protected]> wrote:
> On 05/08/2011 09:05 PM, Hui Zhu wrote:
>>
>> ../../src/gdb/gdbtk/generic/gdbtk-hooks.c: In function 'gdbtk_add_hooks':
>> ../../src/gdb/gdbtk/generic/gdbtk-hooks.c:126: error: passing argument
>> 1 of 'observer_attach_breakpoint_created' from incompatible pointer
>> type
>
> [snip]
>
> I've committed the attached patch to address this. IMO this patch should
> have been necessary years ago! [Better late than never, gdb! :-)]
>
> Thank you for notifying me.
>
> Keith
>
> ChangeLog
> 2011-05-12  Keith Seitz  <[email protected]>
>
>        * generic/gdbtk-hooks.c (gdbtk_create_breakpoint): Change
>        parameter from `int' to `struct breakpoint *'.
>        (gdbtk_delete_breakpoint): Likewise.
>        (gdbtk_modify_breakpoint): Likewise.
>        * generic/gdbtk-bp.c (ALL_BREAKPOINTS): Define.
>        (breakpoint_list): Remove.
>        (breakpoint_list_size): Remove.
>        (Gdbtk_Breakpoint_Init): Remove initialization of breakpoint_list.
>        (gdb_find_bp_at_addr): Rewrite using ALL_BREAKPOINTS.
>        (gdb_find_bp_at_line): Likewise.
>        (gdb_get_breakpoint_info): Likewise.
>        (gdb_get_breakpoint_list): Likewise.
>        (gdbtk_create_breakpoint): Change parameter from `int' to
>        `struct breakpoint *' and update function.
>        (gdbtk_delete_breakpoint): Likewise.
>        (gdbtk_modify_breakpoint): Likewise.
>        (breakpoint_notify): Rewrite using ALL_BREAKPOINTS.
>