Re: [PATCH] Compliancy to windows 64bit

On 03/19/2012 05:08 AM, Roland Schwingel wrote:

> Any comments? Is this ok?

Wow, I had no idea we were harboring such evil code... Passing host 
pointers into the interpreter and back again. Eeeew! [Alas, this portion 
of insight is probably about the oldest...] This whole thing should have 
been done some other way. [But that's probably not the comment you're 
attempting to elicit. :-)]

Just a nit:

> --- gdbtk_orig/generic/gdbtk-stack.c	2012-03-05 09:19:01.000000000 +0100
> +++ gdbtk/generic/gdbtk-stack.c	2012-03-14 11:56:31.851248200 +0100
> @@ -289,7 +289,7 @@
>         return TCL_ERROR;
>       }
>
> -  arguments = (long) clientData;
> +  arguments = clientData!=NULL?1:0;
>
>     /* Initialize the result pointer to an empty list. */
>

This isn't formatted properly. It should be:

arguments = clientData != NULL ? 1 : 0;

Okay with that change.

Keith