Re: [PATCH] Add missing prototype in gdbtk.c

Keith Seitz <[email protected]> Thu, 29 Mar 2012 16:02:09 -0700
Newsgroups gmane.comp.debugging.insight
Message-ID <[email protected]>
On 03/19/2012 05:10 AM, Roland Schwingel wrote:
> Changelog:
>
> 2012-03-19 Roland Schwingel <[email protected]>
>
> * generic/gdbtk.c: Add prototype for close_bfds().
>
> Any comments? Is this ok?

Hmm. There already appears to be a declaration for this in gdbtk.h:

#ifdef _WIN32
extern void close_bfds ();
#endif /* _WIN32 */

Perhaps that check needs updating to "#if defined(_WIN32) || 
defined(_WIN64)"?

[Consider that change pre-approved with updated ChangeLog entry.]

Keith