Re: [PATCH] Add declarations to gdbtk.h

Keith Seitz <[email protected]> Wed, 9 Oct 2019 17:20:29 -0700

Newsgroups	gmane.comp.debugging.insight
Message-ID	<[email protected]>

On 10/7/19 2:09 PM, Christian Biesinger via insight wrote:
> From: Christian Biesinger <[email protected]>
> 
> Currently, gdb/main.c has to declare these two variables in the
> .c file. This patch adds the declarations to the header so that
> gdb can just use them.
> 
> gdbtk/ChangeLog:
> 
> 2019-10-07  Christian Biesinger  <[email protected]>
> 
> 	* generic/gdbtk.h (gdbtk_test): Declare.
>   (external_editor_command): Declare.
>   (file): Prefix Tcl_Interp with "struct"
>   so that this compiles when Tcl headers aren't included.
>   * generic/gdbtk-interp.h:  Likewise.

That looks okay to me. Thank you for thinking of us!

Keith