Re: [PATCH] Add declarations to gdbtk.h

"Christian Biesinger via insight" <[email protected]> Wed, 9 Oct 2019 19:35:15 -0500

Newsgroups	gmane.comp.debugging.insight
Message-ID	<CAPTJ0XF=GeUkHwXWBVHmVyo1h+2BP5L3eWX8LMUx8j=t2V4TTg@mail.gmail.com>

Great thanks! Could you check this in? I don't think I have commit access
to this repository.

Christian

On Wed, Oct 9, 2019, 19:20 Keith Seitz <[email protected]> wrote:

> On 10/7/19 2:09 PM, Christian Biesinger via insight wrote:
> > From: Christian Biesinger <[email protected]>
> >
> > Currently, gdb/main.c has to declare these two variables in the
> > .c file. This patch adds the declarations to the header so that
> > gdb can just use them.
> >
> > gdbtk/ChangeLog:
> >
> > 2019-10-07  Christian Biesinger  <[email protected]>
> >
> >       * generic/gdbtk.h (gdbtk_test): Declare.
> >   (external_editor_command): Declare.
> >   (file): Prefix Tcl_Interp with "struct"
> >   so that this compiles when Tcl headers aren't included.
> >   * generic/gdbtk-interp.h:  Likewise.
>
> That looks okay to me. Thank you for thinking of us!
>
> Keith
>