Re: [PATCH] ROX-Lib get_icon() improvements

2007/12/1 Lennon Cook <[email protected]>:
> The attached patch contains several bugfixes to ROX-Lib2's get_icon()
>  function - it fixes bugs with trying to find a thumbnail when one
>  doesn't exist (I was getting an error about pbuf being referenced
>  before assignment), tries various extra naming schemes for icons, and
>  there is preliminary support for reading globicons.

I've applied some of the bug fixes. I don't understand what the rest does.
e.g. surely this has no effect?

+	def characters(self, chars):
+		if self.in_match:
+			self.icon

Do you have a test case? Why does it return "" instead of None if there is
no icon?


On a slightly related note, I've been patching pygobject to support GIO better.
Perhaps we can remove most of the thumbnails code from ROX-Lib and use
GIO instead?


Cheers,


-- 
Dr Thomas Leonard	http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone