Re: [PATCH] ROX-Lib get_icon() improvements

"Thomas Leonard" <[email protected]> wrote:
> 2007/12/1 Lennon Cook <[email protected]>:
> > The attached patch contains several bugfixes to ROX-Lib2's
> > get_icon() function - it fixes bugs with trying to find a thumbnail
> > when one doesn't exist (I was getting an error about pbuf being
> > referenced before assignment), tries various extra naming schemes
> > for icons, and there is preliminary support for reading globicons.
> 
> I've applied some of the bug fixes. I don't understand what the rest
> does. e.g. surely this has no effect?
> 
> +	def characters(self, chars):
> +		if self.in_match:
> +			self.icon
It looks like I managed to leave the end off that line, somehow - from
memory, it should read:
self.icon += chars

ISTR it didn't quite work for me (which is why I called it 'preliminary
support' in my original mail); this could very easily be why.

> Do you have a test case? Why does it return "" instead of None if
> there is no icon?
Probably me failing to think everything through properly. That
situation isn't unheard of...

> 
> On a slightly related note, I've been patching pygobject to support
> GIO better. Perhaps we can remove most of the thumbnails code from
> ROX-Lib and use GIO instead?
That strikes me as a good idea, particular if equivalent changes are
made (or have already been made) to the filer.

-- 
Lennon Victor Cook
"He who receives an idea from me receives without lessening, as he who
lights his candle at mine receives light without darkening" -- Thomas
Jefferson

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

_______________________________________________
rox-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rox-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIJ3gjSrio52E6Jm8RAoXSAKCimaykul/jnRsja3GXKKSSy6VhVQCeNxHh
TsOpOLVP3pC0l2gZyv+7SBM=
=2Apz
-----END PGP SIGNATURE-----