Re: Building SID

Dave Brolley <[email protected]> Fri, 02 Mar 2007 12:11:50 -0500
Newsgroups gmane.comp.emulators.sid.devel
Message-ID <[email protected]>
Dave Brolley wrote:

> Michael Ambrus wrote:
>
>
>>
>> Compiling the files arm.cxx and compTIMERS.cxx both give the same error:
>>
>> /home/ambrmi09/projects/sid/src/sid/component/timers/arm7t/arm7t-timer.h:142: 
>>
>> error: looser throw specifier for 'virtual
>> armTimerNoSched::~armTimerNoSched()'
>> /home/ambrmi09/projects/sid/src/sid/component/timers/arm7t/arm7t-timer.h:70: 
>>
>> error: overriding 'virtual armTimer::~armTimer() throw ()'
>
> This relates to the removal of throw () specifiers from the SID API 
> recently. The correct patch is to remove the throw specifier on 
> ~armTimer completely. I'll test it and commit it, hopefully today.

I reviewed this again and have committed the attached patch which adds 
the correct throw specifier to the destructor of armTimerNoSched.

Dave

>
sid.throw.ChangeLog (text/plain, 138 B)
2007-03-02  Dave Brolley  <[email protected]>

	* arm7t-timer.h (~armTimerNoSched): New virtual destructor with empty
	throw specifier.
sid.throw.patch.txt (text/plain, 603 B)
Index: sid/component/timers/arm7t/arm7t-timer.h
===================================================================
RCS file: /cvs/src/src/sid/component/timers/arm7t/arm7t-timer.h,v
retrieving revision 1.3
diff -c -p -r1.3 arm7t-timer.h
*** sid/component/timers/arm7t/arm7t-timer.h	12 Feb 2005 16:25:47 -0000	1.3
--- sid/component/timers/arm7t/arm7t-timer.h	2 Mar 2007 17:01:37 -0000
*************** class armTimerNoSched: public armTimer
*** 142,147 ****
--- 142,148 ----
  {
  public:
    armTimerNoSched();
+   ~armTimerNoSched() throw () {}
  
  private:
    callback_pin<armTimerNoSched> clockpin;