Re: Powrprof patches

> Am 19.02.2025 um 23:38 schrieb robert lippmann <[email protected]>:
> 
> Some more follow up questions:
> 
> 1) Since there are a lot of new functions added, should I do an initial patch with winedump producing skeleton code, and have each function just return ERROR_CALL_NOT_IMPLEMENTED?  And then do follow on patches to implement?  Or just do the implementation at the same time?  From a review standpoint, I imagine the first approach is better.

The first approach is generally better. Make sure that every function writes a FIXME to make it obvious a stub is called.

> 2) A bunch of power related GUIDs are defined in winnt.h in the Windows SDK. It seems like they should be in the power headers.  Should I follow the SDK?

Yeah, follow the SDK. At least in theory our headers should be a drop in replacement for Microsoft's, although in practice that doesn't get tested much.

> 3) For new files I’ll need to create, do I set the copyright name to me?  Or Alexandre?

Yourself