Re: Powrprof patches

Alexandre Julliard <[email protected]> Thu, 20 Feb 2025 12:11:37 +0100
Newsgroups gmane.comp.emulators.wine.devel
Message-ID <878qq06fbq.fsf@wine>
Stefan Dösinger <[email protected]> writes:

>> Am 19.02.2025 um 23:38 schrieb robert lippmann <[email protected]>:
>> 
>> Some more follow up questions:
>> 
>> 1) Since there are a lot of new functions added, should I do an
>> initial patch with winedump producing skeleton code, and have each
>> function just return ERROR_CALL_NOT_IMPLEMENTED?  And then do follow
>> on patches to implement?  Or just do the implementation at the same
>> time?  From a review standpoint, I imagine the first approach is
>> better.
>
> The first approach is generally better. Make sure that every function writes a FIXME to make it obvious a stub is called.

Unless it's a COM interface, you don't want to add skeleton code. Just
list the functions as stub in the spec file, and implement only the ones
that are called by the application.

-- 
Alexandre Julliard
[email protected]