Re: [PATCH]hotkey for mousegrab

Hello!
First of all, sorry it took me so long to look into this again.
On Wednesday 04 May 2005 04:46, Ove Kaaven wrote:
> tir, 12,.04.2005 kl. 23.43 +0200, skrev Fabian Bieler:
> > This is a small hack to disable and re-enable DXGrab via Ctrl-F9.
>
> Nice, but there are a few things.
>
> * The variable "want_grab" was meant to control whether to regrab the
> mouse when focus is restored. It would be cleaner if you made sure this
> remained false when grabbing is suppressed the same way it remains false
> when DXGrab is disabled.
I'm not sure about this. If I change "want_grab" when supressing grab, I don't 
know if I have to re-install grabs when suppressing stops. of course there 
are ways around this but I feel using "want_grab" for this purpose is the 
best way without changing huge amounts of code. However, if you insist on 
changing "want_grab" I'll do so.
>
> * Ctrl-F9 may be used by some games. Preferably the keystroke should be
> configurable somehow. Perhaps XStringToKeysym() can be used for that.
No problem. do you think it will be sufficient to make F9 configurable or 
should the modifier-key be changeable, too?
>
> * You mention Ctrl-F11 is the config patch, but don't implement it. You
> should probably not mention it then.
Sorry about that. I tried to implement a hotkey to switch fullscreen/desktop 
mode on runtime. unfortunately I ran into a number of problems which I fear 
are beyond my scope to fix.

Fabian