Re: makefile patches from MacPorts
Jeffrey Walton <[email protected]> Sun, 5 Apr 2015 20:13:22 -0400
| Newsgroups | gmane.comp.encryption.cryptlib |
|---|---|
| Message-ID | <CAH8yC8m7S=TXbFgHW_71JGnm09jWkj5-Rm=EvK1nFoZQvX+x=g@mail.gmail.com> |
On Thu, Apr 2, 2015 at 11:41 PM, Ryan Schmidt <[email protected]> wrote: > ... > We append to CFLAGS, rather than overwriting them, and remove the line that clears LDFLAGS. It is customary for users to want to be able to specify CFLAGS and LDFLAGS (and CXXFLAGS and CPPFLAGS) at the command line, and we do want to do that in MacPorts. > There's one more small issue here (if interested): CFLAGS += -c -D__UNIX__ -DNDEBUG -I. By placing the library's CFLAGS after the user's CFLAGS, the library effectively overrides anything that conflicts. I think it should be the other way around: the user's CFLAGS are appended to the library's CFLAGS so the user's flags have precedence. We did the same in OWASP's ESAPI C++ so we did not step on user's CFLAGS/CXXFLAGS. See https://code.google.com/p/owasp-esapi-cplusplus/source/browse/trunk/GNUmakefile. Jeff _______________________________________________ Cryptlib mailing list [email protected] via Mail: [email protected] Archive: ftp://ftp.franken.de/pub/crypt/cryptlib/archives/ http://news.gmane.org/gmane.comp.encryption.cryptlib Posts from non-subscribed addresses are blocked to prevent spam, please subscribe in order to post messages.