Re: makefile patches from MacPorts

On Apr 5, 2015, at 7:13 PM, Jeffrey Walton wrote:

> On Thu, Apr 2, 2015 at 11:41 PM, Ryan Schmidt wrote:
>> ...
>> We append to CFLAGS, rather than overwriting them, and remove the line that clears LDFLAGS. It is customary for users to want to be able to specify CFLAGS and LDFLAGS (and CXXFLAGS and CPPFLAGS) at the command line, and we do want to do that in MacPorts.
>> 
> There's one more small issue here (if interested):
> 
>    CFLAGS += -c -D__UNIX__ -DNDEBUG -I.
> 
> By placing the library's CFLAGS after the user's CFLAGS, the library
> effectively overrides anything that conflicts.
> 
> I think it should be the other way around: the user's CFLAGS are
> appended to the library's CFLAGS so the user's flags have precedence.
> We did the same in OWASP's ESAPI C++ so we did not step on user's
> CFLAGS/CXXFLAGS. See
> https://code.google.com/p/owasp-esapi-cplusplus/source/browse/trunk/GNUmakefile.

You may be right. Certainly, any of the project's own -I flags must appear before any the user would specify. If the prefix is /opt/local, "-I/opt/local/include -I." would result in headers from a previously-installed cryptlib being used during the build, which is wrong; "-I. -I/opt/local/include" is what should be on the compile line. The same may apply to other types of flags.


_______________________________________________
Cryptlib mailing list
[email protected] via Mail: [email protected]
Archive: ftp://ftp.franken.de/pub/crypt/cryptlib/archives/
http://news.gmane.org/gmane.comp.encryption.cryptlib
Posts from non-subscribed addresses are blocked to prevent spam, please
subscribe in order to post messages.