Re: [RFC] [PATCH] ext3 nanosecond timestamps
Andreas Dilger <[email protected]>
| Newsgroups | gmane.comp.file-systems.ext2.devel |
|---|---|
| Message-ID | <[email protected]> |
On Jun 21, 2006 22:38 +0200, Johann Lombardi wrote:
> Hi Andreas,
>
> > +#define EXT3_INODE_SET_XTIME(xtime, extra_xtime, inode, raw_inode) \
> > +do { \
> > + (raw_inode)->xtime = cpu_to_le32((inode)->xtime.tv_sec); \
> > + \
> > + if (offsetof(typeof(*raw_inode), extra_xtime) - \
> > + offsetof(typeof(*raw_inode), i_extra_isize) + \
> > + sizeof((raw_inode)->extra_xtime) <= (raw_inode)->i_extra_isize) \
>
> these macros directly use raw_inode->i_extra_isize.
> Shouldn't it be le16_to_cpu(raw_inode->i_extra_isize) instead?
You're right of course. Will submit an updated patch after I've given some
more time for other comments.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642