Re: [RFC] [PATCH] ext3 nanosecond timestamps

>  	__le16	i_extra_isize;
>  	__le16	i_pad1;
> +	__le32	i_ctime_extra;	/* extra Change time      (nsec << 2 | epoch) */
> +	__le32	i_mtime_extra;	/* extra Modification time(nsec << 2 | epoch) */
> +	__le32	i_atime_extra;	/* extra Access time      (nsec << 2 | epoch) */
> +	__le32  i_extra_reserved1;
[...]
> +	if (offsetof(typeof(*raw_inode), extra_xtime) -			       \
> +	    offsetof(typeof(*raw_inode), i_extra_isize) +		       \
> +	    sizeof((raw_inode)->extra_xtime) <=	(raw_inode)->i_extra_isize)    \

If there's enough space for i_ctime_extra but not for i_mtime_extra,
ns timestamp will be supported for ctime but not for mtime.
I'd expect ns timestamps to be used only if the inode has space for _all_ extra
timestamps. What do you think?

Johann

All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642