Re: [RFC][Update][Patch 8/16]Avoid potential block overflow when writing journal metadata tags
Andreas Dilger <[email protected]>
| Newsgroups | gmane.comp.file-systems.ext2.devel |
|---|---|
| Message-ID | <[email protected]> |
On Jun 29, 2006 17:18 -0700, Mingming Cao wrote: > When writing block numbers into a journal descriptor block, don't write > the top 32 bits of a tag unless we're using a 64-bit journal. That > avoids any possibility of overflowing off the end of the descriptor > block in the case where the last 32-bit tag only just fits into the > descriptor block. > > Also cleans up the tag handling slightly by introducing new macros for > the size of 32- and 64-bit descriptor tags. This should probably be folded into the previous patch, since it doesn't make sense to be sending a separate patch that is broken... Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642