Re: [RFC][Update][Patch 15/16] compile warning fix and change 64bit to INCOMPAT feature
Andreas Dilger <[email protected]>
| Newsgroups | gmane.comp.file-systems.ext2.devel |
|---|---|
| Message-ID | <[email protected]> |
On Jun 29, 2006 17:19 -0700, Mingming Cao wrote: > Change the 64bit to INCOMPAT feature, and fixed compile warning in the 64bit_metadata patch. > @@ -636,7 +637,6 @@ static inline struct ext3_inode_info *EX > #define EXT3_FEATURE_RO_COMPAT_SPARSE_SUPER 0x0001 > #define EXT3_FEATURE_RO_COMPAT_LARGE_FILE 0x0002 > #define EXT3_FEATURE_RO_COMPAT_BTREE_DIR 0x0004 > -#define EXT3_FEATURE_RO_COMPAT_64BIT 0x0010 > > #define EXT3_FEATURE_INCOMPAT_COMPRESSION 0x0001 > #define EXT3_FEATURE_INCOMPAT_FILETYPE 0x0002 > @@ -644,16 +644,17 @@ static inline struct ext3_inode_info *EX > #define EXT3_FEATURE_INCOMPAT_JOURNAL_DEV 0x0008 /* Journal device */ > #define EXT3_FEATURE_INCOMPAT_META_BG 0x0010 > #define EXT3_FEATURE_INCOMPAT_EXTENTS 0x0040 /* extents support */ > +#define EXT3_FEATURE_INCOMPAT_64BIT 0x0080 > > #define EXT3_FEATURE_COMPAT_SUPP EXT2_FEATURE_COMPAT_EXT_ATTR > #define EXT3_FEATURE_INCOMPAT_SUPP (EXT3_FEATURE_INCOMPAT_FILETYPE| \ > EXT3_FEATURE_INCOMPAT_RECOVER| \ > EXT3_FEATURE_INCOMPAT_META_BG| \ > - EXT3_FEATURE_INCOMPAT_EXTENTS) > + EXT3_FEATURE_INCOMPAT_EXTENTS| \ > + EXT3_FEATURE_INCOMPAT_64BIT) > #define EXT3_FEATURE_RO_COMPAT_SUPP (EXT3_FEATURE_RO_COMPAT_SPARSE_SUPER| \ > EXT3_FEATURE_RO_COMPAT_LARGE_FILE| \ > - EXT3_FEATURE_RO_COMPAT_BTREE_DIR| \ > - EXT3_FEATURE_RO_COMPAT_64BIT) > + EXT3_FEATURE_RO_COMPAT_BTREE_DIR) This (and the other jbd patches) should again just be merged into the original patch that added these lines. It doesn't make sense to have an intermediate patch that is broken, especially if something prevents the later patches from being accepted. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642