Re: [PATCH] 00/13 e2fsprogs-1.39 extent checking improvements

On Aug 02, 2006  14:10 -0400, Jarod Wilson wrote:
> On Wed, 2006-08-02 at 10:24 -0600, Andreas Dilger wrote:
> > I've created an updated patchset (as discussed on the ext4 concall) with
> > improved checking for the extents format, as well as improved checking
> > for corrupted indirect/index blocks.  In addition, there are a bunch of
> > cleanups to e2fsprogs that I have already submitted to Ted.
> 
> I was on the call, but had to step away to attend to other business...
> Was this patchset intended to supplant or augment the 48bitext3
> patchset? Or neither? I ask because I see things in one that aren't in
> the other and vice versa, but the two collide in a few places. Haven't
> yet started in on the collisions to try to resolve them, thought I'd get
> clarification first.

This is intended only to replace the 32-bit extents support in the ext4
e2fsprogs patchset.  No effort has been made yet to integrate the two.
I had to fix up the extents support to resolve some customer bugs (on
32-bit extent-mapped filesystems), and figured the patches would at
least be useful as a point of discussion before they can be integrated.

I currently don't have any time to work further on these patches, so
I'm posting them instead of letting them sit around unseen.

NB - there is a single failure in "make check" from the f_lotsbad
test, which is a failure in even the unpatched e2fsprogs-1.39.  The
problem was hidden because a very-corrupt inode was causing pass1
to restart after a 4GB directory was partly fixed.  With the "verify
indirect blocks" patch the very-corrupt inode is being discarded
outright and pass1 does not restart.  It is possible to re-run an
unpatched e2fsprogs on that directory inode repeatedly without fixing it.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV