[PATCH 2/2] JFS: Need to be root to create files with security context

[email protected] (Dave Kleikamp) Wed, 13 Jul 2005 09:40:49 -0500 (CDT)
Newsgroups gmane.comp.file-systems.jfs.patches
Message-ID <[email protected]>
JFS: Need to be root to create files with security context

It turns out this is due to some inverted logic in xattr.c

Signed-off-by: Dave Kleikamp <[email protected]>

---
commit 59192ed9e7aa81b06a1803661419f7261afca1ad
tree 31f592365ad2ecf5eb606de10290da502fc7eb74
parent 6211502d7ee9e515e4458d0c0ebfbb70553dc7de
author Ian Dall <[email protected]> Wed, 13 Jul 2005 09:15:18 -0500
committer Dave Kleikamp <[email protected]> Wed, 13 Jul 2005 09:15:18 -0500

 fs/jfs/xattr.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
--- a/fs/jfs/xattr.c
+++ b/fs/jfs/xattr.c
@@ -790,12 +790,12 @@ static int can_set_xattr(struct inode *i
 		 */
 		return can_set_system_xattr(inode, name, value, value_len);
 
-	if(strncmp(name, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) != 0)
+	if(strncmp(name, XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN) == 0)
 		return (capable(CAP_SYS_ADMIN) ? 0 : -EPERM);
 
 #ifdef CONFIG_JFS_SECURITY
 	if (strncmp(name, XATTR_SECURITY_PREFIX, XATTR_SECURITY_PREFIX_LEN)
-	    != 0)
+	    == 0)
 		return 0;	/* Leave it to the security module */
 #endif
 		


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar