[PATCH 1/2] JFS: Allow security.* xattrs to be set on symlinks

[email protected] (Dave Kleikamp) Wed, 13 Jul 2005 09:40:49 -0500 (CDT)
Newsgroups gmane.comp.file-systems.jfs.patches
Message-ID <[email protected]>
JFS: Allow security.* xattrs to be set on symlinks

All of the different xattr namespaces have different rules.
user.* and ACL's are not allowed on symlinks, and since these were the
first xattrs implemented, I assumed there was no need to support xattrs
on symlinks.  This one-line patch should fix it.

Signed-off-by: Dave Kleikamp <[email protected]>

---
commit 6211502d7ee9e515e4458d0c0ebfbb70553dc7de
tree 24ab6b567f793f8dd1c1e3458769290df2bf8f52
parent f7f24758ac98a506770bc5910d33567610fa3403
author Dave Kleikamp <[email protected]> Wed, 13 Jul 2005 09:07:53 -0500
committer Dave Kleikamp <[email protected]> Wed, 13 Jul 2005 09:07:53 -0500

 fs/jfs/xattr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
--- a/fs/jfs/xattr.c
+++ b/fs/jfs/xattr.c
@@ -781,7 +781,7 @@ static int can_set_xattr(struct inode *i
 	if (IS_RDONLY(inode))
 		return -EROFS;
 
-	if (IS_IMMUTABLE(inode) || IS_APPEND(inode) || S_ISLNK(inode->i_mode))
+	if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
 		return -EPERM;
 
 	if(strncmp(name, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN) == 0)


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar