Re: Run entire codebase through GNU Indent?
Frank Trampe <[email protected]>
| Newsgroups | gmane.comp.fonts.fontforge.devel |
|---|---|
| Message-ID | <CANkSbhq+76LjLvSoq=u+khswuqxzu8=1eF7ZyaXf44ksOEg-FQ@mail.gmail.com> |
I spend a lot of time reverse engineering stuff in Fontforge, and I don't find the present (somewhat inconsistent) indentation style a big impediment to my work. I sometimes restyle badly formatted code as I comment it, but it's more the vast blocks of uncommented code that puzzle me, not how those are indented. On Fri, Jul 11, 2014 at 1:09 PM, Thomas Shinnick <[email protected]> wrote: > What will happen to lines such as this (python.c ~ line 8058): > for ( old = sc->possub; old!=NULL && old->subtable!=sub; prev=old, > old=old->next ); > > I'm of two minds, hating the mooted massive disfigurement and use of > shredding, but liking the regularizing of code expressions to something > more glanceable. > > (If you'd asked before I saw the above line of code, I'd'a just said > 'no'. But the above is the knowing output of someone far too intimate with > C compilers :) ) > > > On Fri, Jul 11, 2014 at 12:28 PM, Daniel Kahn Gillmor < > [email protected]> wrote: > >> It's also worth noting that git blame has a -w option, which is >> documented as: >> >> -w >> Ignore whitespace when comparing the parent’s version and the >> child’s to find where the lines came from. >> >> So at least in cases where GNU indent doesn't add or remove linebreaks, >> people don't even need to take Felipe's workaround. >> >> a codebase cleanup, ideally coupled with some mechanism to prevent >> future drift from the chosen convention, will be healthier for the >> project in the long term, and the sooner it's done the better. >> >> rip off the bandage :) >> >> --dkg >> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Fontforge-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/fontforge-devel >> >> > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Fontforge-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/fontforge-devel > > ------------------------------------------------------------------------------ _______________________________________________ Fontforge-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fontforge-devel