Re: Run entire codebase through GNU Indent?

On July 11, 2014 06:49:18 PM Frank Trampe wrote:
> I spend a lot of time reverse engineering stuff in Fontforge, and I
> don't find the present (somewhat inconsistent) indentation style a big
> impediment to my work. I sometimes restyle badly formatted code as I
> comment it, but it's more the vast blocks of uncommented code that
> puzzle me, not how those are indented.

Likewise.

I find no value in aligning the code just because a tool exists that can do 
it. It adds zero code fixes or improvements. What the code definitely needs 
is commenting, and I've said that over and over again.

...for myself, the old code staying the way it is, also acts like a mile 
marker to tell me that that code has not been analyzed yet. ...and as I go 
through that particular bit of code, I re-align to what I find preferable.

NOTE: I really don't like code of this manner at all since I end up 
scrolling up-down to view a portion of code instead of seeing more code per 
screenfull:
int *
main(arg argv)
  {
if ( something )
  {
  }
else
  {
  }
  return x;
  }
If someone decides to align everything for the sake of alignment, I've lost 
all hinting as to what's been touched/improved or not, and to that, I say, 
you've touched everything - and therefore - you just inherited maintaining 
all of FontForge yourself.

Was this question brought up by developers maintaining FontForge, or by 
people that look at code but haven't contributed improvements?

If it was asked by developers working on code, it's a reasonable question 
and problem to resolve.
If it was asked by someone that has not helped improve FontForge, I don't 
see the value in adding one more impediment to those who are "actually" 
working on trying to improve the code.

------------------------------------------------------------------------------