Re: Is fontforge/http.c used?

It seemed that the only calls to functions in http.c were from the Open
Font Library uploader, so somebody (Adrien?) removed the entire file.
Compilation was successful, but trying to open the Generate Fonts dialogue
box caused a crash on a corrupt function pointer. We tried to figure out
what was wrong but failed to do so in a reasonable period of time, so we
needed to revert the change in order to keep the master branch functional.




On Sat, Sep 6, 2014 at 1:15 AM, Thomas Shinnick <[email protected]> wrote:

> Yes, I saw that.
>
> The thing is, that when it was hard to make other options work for users
> it was a nice feature to provide a capability to do http/ftp/whatever.
>
> But adding such a basic capability *within* your own program has the risks
> of being both inadequate at some network interaction or another while also
> being bug-ridden, because that's not what your program is all about!
>
> (Look for the realloc in http.c - all of a sudden the caller is looking in
> the wrong buffer (now free()d!!) upon return from HttpGetBuf() - is that
> six-legged or eight-legged? - with threads, must be eight-legged)
>
> Doing a call out to wget or another utility would be vastly preferable,
> notwithstanding the sere utility landscape for users that is Windows.
> Implementing the equivalent feature in an external utility, perhaps in
> Python, would be better.
>
> You say "We removed it previously as part of a larger pull request that
> removed support for uploading to the Open Font Library."  So it was a
> change solely to remove the "upload to OFL" thing, or was it intended to
> jettison all this networking stuff?
>
>
> On Fri, Sep 5, 2014 at 10:14 PM, Dave Crossland <[email protected]> wrote:
>
>> Generate dialog has a upload to OFLB option.
>>
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds.  Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> fontforge-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/fontforge-devel
> http://fontforge.10959.n7.nabble.com/Developer-f3.html
>
>

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/

_______________________________________________
fontforge-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fontforge-devel
http://fontforge.10959.n7.nabble.com/Developer-f3.html