Re: FIX/PATCH Xorg compile on DragonFlyBSD

David Rhodus wrote:
> 
> On Sat, 06 Nov 2004 23:26:55 +0100, Roland Mainz
> <[email protected]> wrote:
> > David Rhodus wrote:
> > > We have put together a trivial patch set to allow Xorg to compile
> > > under DragonFlyBSD.   Here is the URL for the patch set
> > > http://leaf.dragonflybsd.org/~drhodus/xorg-dragonfly.tar.gz
> >
> > Uhm... did you see https://freedesktop.org/bugzilla/show_bug.cgi?id=1712
> > yet ?
> 
> No, I haven't seen those.  But these should apply cleanly with the cvs
> tree as of yesterday.

Could you please sync with the DragonFly people in
https://freedesktop.org/bugzilla/show_bug.cgi?id=1712 ? There should
really only _one_ patch for DraginFly support and not multiple.

> > > It would be great to see this go in before the new release.
> >
> > Please define "new release" ? Do you mean the upcoming X11R6.8.2
> > maintaince release or X11R6.9.0 (e.g. the next major release) ?
> 
> Yeah, the 6.8.2 release.  These are really trivial changes I can't
> think of a reason to hold out of them until the next major release.

Erm... the X11R6.8.2 release is targeted as a bugfix release where new
features should be avoided (I said "should", not "must" :)
Supporting a whole new platform is clearly a "feature". However I am not
100% against that idea to have such a patch in X11R6.8.2 as DragonFly is
AFAIK a FreeBSD4.x derivate and not really an all-new platform. But I
expect great resistance from other release-wrangers so I'd like put the
barrier slightly higher for such a patch than for others (BTW: please
read http://wiki.freedesktop.org/XOrg/X11R682ReleasePlan ; please look
at the schedule for patches - such a patch doesn't fall into the
category "critical" so you have to hurry up... ;-/).

My criterias would be:
1. You must have a good reason why you want that patch in X11R6.8.x -
something like that "... DragonFly people want to ship their next
release within the next six month and want to include X11R6.8.x with
it..." (e.g. you can't wait (or want to wait) until the next major
release (X11R6.9.0) is out)
2. Find two other people from the DragonFly project who _TEST_ the patch
whether it really _WORKS_. These two people should then "vouch" for that
patch (I'd like to avoid having broken or only half-working platform
support in the branch)
3. The risk of the patch should be _low_, which means there should only
a small amount of changes and the changes should be isolated from the
other platforms (e.g. they should not affect other platforms if
possible)
4. The patch MUST be commited to Xorg CVS HEAD _first_.

That are just my personal opinions for now, other release-wrangers may
come up with more items. And even if you have met points 1-4 then it's
still up to the release-wrangers (e.g. a conference call after the day
when the patch has been posted to bugzilla and the two vouchers have
confirmed that it works) to approve or reject the patch.

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) [email protected]
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)