Re: libXt, libXmu, libXaw, libXtst, libdps

Keith Packard <[email protected]> Wed, 10 Dec 2003 21:30:18 -0800
Newsgroups gmane.comp.freedesktop.xlibs.general
Message-ID <[email protected]>
Around 20 o'clock on Dec 10, Eric Anholt wrote:

> I think keithp just did the conversion of libXt himself when he needed
> it, not remembering that you had done it.  I hadn't looked at your code
> yet for integrating it (and making you a committer) since I didn't know
> what the proper fix for Xalloca.h was.

Oops, yes Eric is quite correct.  I had an urgent need to fix a bug in Xt
that was causing my translucent xterm to not work right
(XtDefaultForeground/Background *always* used BlackPixel/WhitePixel, even
on non-default visuals)

I appoligize for not starting from your changes; mine were made quickly 
and without a lot of care (hence the broken alloca problem).

The basic plan for importing any new library is to take the existing CVS 
directory from the XFree86 repository and just dump it into /cvs/xlibs.  
Ideally, one would then remember to tag that version (I suspect I've 
forgotten that in more than one directory).  Check it out, make changes 
and commit them so that the resulting repository contains the necesary 
autofoo files.

Taking a snapshot of the current XFree86 CVS HEAD is not nearly as useful 
as you lose all of the change history; it's important to be able to go 
back and see what changes have been made over the last several years; we 
found some significant bugs had accidentally been introduced into Xlib in 
the course of updating the code to use prototypes, and having the CVS 
history made it easy to go back and see what was changed.  It's like being 
a physician with a new patient and no medical records -- you have no idea 
what previous surgeries or major illness may be contributing to any 
current malady.

Please feel free to whack Xt to suit; I mostly didn't want to lose the 
bug fix I'd made.  If you've got autofoo stuff working, you may feel free 
to replace the stuff in place as I'm not proud of it in any way.

-keith