Re: [PATCH 2/13] Coarray shared memory library

Tobias Burnus <[email protected]>
Newsgroups gmane.comp.gcc.patches,gmane.comp.gcc.fortran
Message-ID <[email protected]>
Jerry D wrote:
>      Fortran: Small fixes of coarray routines handling and code gen.
>      
>      gcc/fortran/ChangeLog:
>      
>              * check.cc (gfc_check_image_status): Fix argument index of team=
>              argument for correct error message.
>              * trans-intrinsic.cc (conv_intrinsic_image_status): Team=
>              argument is optional and is a pointer to the team handle.
>              * trans-stmt.cc (gfc_trans_sync): Make images argument also a
>              dereferencable pointer.  But treat errmsg as a pointer to a
>              char array like in all other functions.
>      
>      gcc/testsuite/ChangeLog:
>      
>              * gfortran.dg/coarray_sync_memory.f90: Adapt grep pattern for
>              msg being only &msg.

It seems as if a testcase for 'image_status(image[, team])' is missing
as only the 'sync' change shows up in the testsuite.

Can someone create a test for the two bits in it? A compile-time check
and a runtime check? - Or is this covered anywhere else?

Otherwise, the patch LGTM.

Tobias
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.