Re: [PATCH 2/13] Coarray shared memory library
Andre Vehreschild <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <20260211143844.59e065b8@vepi2> |
Hi Tobias, tests for image_status() w/ some/all arguments are in the tests: image_status_1.f08 for compile time tests, and image_status_2.f08 for runtime tests. May be the test just has been added by a different commit. Preparing these patches has taken some time and it is possible, that the changes were accidently moved to an earlier/later commit. Shall we remedy this? Regards, Andre On Wed, 11 Feb 2026 14:08:17 +0100 Tobias Burnus <[email protected]> wrote: > Jerry D wrote: > > Fortran: Small fixes of coarray routines handling and code gen. > > > > gcc/fortran/ChangeLog: > > > > * check.cc (gfc_check_image_status): Fix argument index of > > team= argument for correct error message. > > * trans-intrinsic.cc (conv_intrinsic_image_status): Team= > > argument is optional and is a pointer to the team handle. > > * trans-stmt.cc (gfc_trans_sync): Make images argument also a > > dereferencable pointer. But treat errmsg as a pointer to a > > char array like in all other functions. > > > > gcc/testsuite/ChangeLog: > > > > * gfortran.dg/coarray_sync_memory.f90: Adapt grep pattern for > > msg being only &msg. > > It seems as if a testcase for 'image_status(image[, team])' is missing > as only the 'sync' change shows up in the testsuite. > > Can someone create a test for the two bits in it? A compile-time check > and a runtime check? - Or is this covered anywhere else? > > Otherwise, the patch LGTM. > > Tobias > -- Andre Vehreschild * Email: vehre ad gmx dot de