Re: [LTO merge][0/15] Description of the final 15 patches

On Mon, 28 Sep 2009, Diego Novillo wrote:

> I will be sending the final 15 patches to bring all the
> functionality from the LTO branch.  I tried to divide the patches
> along maintainer lines, but there are some overlaps

I'll go through the individual patches later, but a general comment:

You say "tested on x86_64".  More detail is needed.  Have you tested both 
LTO-enabled and LTO-disabled configurations, making sure there are no 
regressions in each case?  I think such testing of both configurations is 
needed.  In addition, an LTO-enabled cross from a non-ELF host to an ELF 
target should be tested (there are five non-ELF hosts in the secondary 
platforms list for 4.5; any one of them could be used for this, or a 
non-ELF host not on that list; I realise gold's plugin support may not yet 
be portable to such hosts so that part of the patch may not be testable 
for this case).

-- 
Joseph S. Myers
[email protected]