Re: Ping [PATCH v2] Add attribute and pragma for coverage suppression
Jørgen Kvalsvik <[email protected]>
| Newsgroups | gmane.comp.gcc.patches |
|---|---|
| Message-ID | <[email protected]> |
On 7/31/26 17:53, Joseph Myers wrote: > On Wed, 8 Jul 2026, Jørgen Kvalsvik wrote: > >>> +/* Handle the "disable_coverge" attribute. We don't really do anything >>> here, >>> + just check later if it is set. */ > > Is it "suppress_coverage" or "disable_coverge"? The comment seems > inconsistent with the implementation. It is suppress_coverage, apparently I missed an occurrence there. Search-and-replace is hard. I'll fix it right away. > > This is not a review of the rest of the patch (which is not mainly a > front-end patch). > Sure. Jan has already approved the gcov-, tree-profile, and tree-cfg parts (very tightly connected), does that mean the front-end change is fine, too? Thanks, Jørgen