[binutils-gdb] GDB: testsuite: server: Don't return -1 from top-level (sed)

Thiago Bauermann via Gdb-cvs <[email protected]>
Newsgroups gmane.comp.gdb.cvs
Message-ID <[email protected]> 
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=111c2f0bcc71848987c83642ebd41df033cee6aa

commit 111c2f0bcc71848987c83642ebd41df033cee6aa
Author: Thiago Jung Bauermann <[email protected]>
Date:   Wed Apr 29 20:04:21 2026 -0300

    GDB: testsuite: server: Don't return -1 from top-level (sed)
    
    This patch is purely the result of running:
    
    $ sed -i 's/^    return -1/    return/' *.exp*
    
    inside gdb/testsuite/gdb.server.
    
    Approved-By: Tom Tromey <[email protected]>

Diff:
---
 gdb/testsuite/gdb.server/build-id-seqno.exp                | 4 ++--
 gdb/testsuite/gdb.server/connect-stopped-target.exp        | 2 +-
 gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp   | 2 +-
 gdb/testsuite/gdb.server/connect-without-multi-process.exp | 2 +-
 gdb/testsuite/gdb.server/ext-attach.exp                    | 2 +-
 gdb/testsuite/gdb.server/ext-run.exp                       | 2 +-
 gdb/testsuite/gdb.server/ext-wrapper.exp                   | 2 +-
 gdb/testsuite/gdb.server/extended-remote-restart.exp       | 2 +-
 gdb/testsuite/gdb.server/file-transfer.exp                 | 2 +-
 gdb/testsuite/gdb.server/inferior-args.exp                 | 2 +-
 gdb/testsuite/gdb.server/monitor-exit-quit.exp             | 2 +-
 gdb/testsuite/gdb.server/no-thread-db.exp                  | 2 +-
 gdb/testsuite/gdb.server/pread-offset-size.exp             | 2 +-
 gdb/testsuite/gdb.server/remote-read-msgs.exp              | 4 ++--
 gdb/testsuite/gdb.server/run-without-local-binary.exp      | 2 +-
 gdb/testsuite/gdb.server/server-connect.exp                | 2 +-
 gdb/testsuite/gdb.server/server-exec-info.exp              | 2 +-
 gdb/testsuite/gdb.server/server-kill-python.exp            | 2 +-
 gdb/testsuite/gdb.server/server-kill.exp                   | 2 +-
 gdb/testsuite/gdb.server/server-mon.exp                    | 2 +-
 gdb/testsuite/gdb.server/server-pipe.exp                   | 2 +-
 gdb/testsuite/gdb.server/server-run.exp                    | 2 +-
 gdb/testsuite/gdb.server/solib-list.exp                    | 2 +-
 gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp    | 2 +-
 gdb/testsuite/gdb.server/stop-reply-no-thread.exp          | 2 +-
 gdb/testsuite/gdb.server/sysroot.exp                       | 2 +-
 gdb/testsuite/gdb.server/target-exec-file.exp              | 4 ++--
 gdb/testsuite/gdb.server/twice-connect.exp                 | 2 +-
 gdb/testsuite/gdb.server/wrapper.exp                       | 2 +-
 29 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/gdb/testsuite/gdb.server/build-id-seqno.exp b/gdb/testsuite/gdb.server/build-id-seqno.exp
index 44bdb09b60a..1fa27e80aa0 100644
--- a/gdb/testsuite/gdb.server/build-id-seqno.exp
+++ b/gdb/testsuite/gdb.server/build-id-seqno.exp
@@ -36,12 +36,12 @@ require allow_gdbserver_tests
 standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile] == -1} {
-    return -1
+    return
 }
 
 # Split out BINFILE.debug.  Remove debug from BINFILE.
 if {[gdb_gnu_strip_debug $binfile] != 0} {
-    return -1
+    return
 }
 
 # Get the '.build-id/xx/xxx...xxx' part of the filename.
diff --git a/gdb/testsuite/gdb.server/connect-stopped-target.exp b/gdb/testsuite/gdb.server/connect-stopped-target.exp
index cfe38fcbfc6..74ccd774561 100644
--- a/gdb/testsuite/gdb.server/connect-stopped-target.exp
+++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp
@@ -26,7 +26,7 @@ standard_testfile
 set executable ${testfile}
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 proc do_test {nonstop} {
diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
index fcdc6978d61..7e2b33e09a9 100644
--- a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
+++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp
@@ -28,7 +28,7 @@ standard_testfile
 require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" $testfile $srcfile debug] } {
-    return -1
+    return
 }
 
 # Test connecting GDB to GDBserver without loading a symbol file.
diff --git a/gdb/testsuite/gdb.server/connect-without-multi-process.exp b/gdb/testsuite/gdb.server/connect-without-multi-process.exp
index 4b41f461a79..33787acded5 100644
--- a/gdb/testsuite/gdb.server/connect-without-multi-process.exp
+++ b/gdb/testsuite/gdb.server/connect-without-multi-process.exp
@@ -23,7 +23,7 @@ require allow_gdbserver_tests
 standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Test spawning gdbserver with a program, connect to it and run to
diff --git a/gdb/testsuite/gdb.server/ext-attach.exp b/gdb/testsuite/gdb.server/ext-attach.exp
index 0dd02c145ac..cb4c1277228 100644
--- a/gdb/testsuite/gdb.server/ext-attach.exp
+++ b/gdb/testsuite/gdb.server/ext-attach.exp
@@ -27,7 +27,7 @@ require allow_gdbserver_tests
 require can_spawn_for_attach
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Run the test.  TARGET_NON_STOP and TARGET_ASYNC should be 'on'
diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp
index 83de771902b..4fb2fe004f2 100644
--- a/gdb/testsuite/gdb.server/ext-run.exp
+++ b/gdb/testsuite/gdb.server/ext-run.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 # allow_xml_test must be called while gdb is not running.
diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp
index 836c32a7574..912a8ce3770 100644
--- a/gdb/testsuite/gdb.server/ext-wrapper.exp
+++ b/gdb/testsuite/gdb.server/ext-wrapper.exp
@@ -22,7 +22,7 @@ standard_testfile wrapper.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {
diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp
index 5fe4ebd5729..f10d2f374c0 100644
--- a/gdb/testsuite/gdb.server/extended-remote-restart.exp
+++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp
@@ -48,7 +48,7 @@ if { [info proc gdb_reconnect] == "" } {
 standard_testfile
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Core of the test.  DO_KILL_P controls whether we kill one of the
diff --git a/gdb/testsuite/gdb.server/file-transfer.exp b/gdb/testsuite/gdb.server/file-transfer.exp
index f33c589c961..a4517582b25 100644
--- a/gdb/testsuite/gdb.server/file-transfer.exp
+++ b/gdb/testsuite/gdb.server/file-transfer.exp
@@ -23,7 +23,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an
diff --git a/gdb/testsuite/gdb.server/inferior-args.exp b/gdb/testsuite/gdb.server/inferior-args.exp
index 312e756f0d8..f6ad3e69b40 100644
--- a/gdb/testsuite/gdb.server/inferior-args.exp
+++ b/gdb/testsuite/gdb.server/inferior-args.exp
@@ -35,7 +35,7 @@ if { $gdbserver == "" } {
 
 standard_testfile
 if {[build_executable "failed to prepare" $testfile $srcfile]} {
-    return -1
+    return
 }
 
 # EXTENDED_P is a boolean, when true gdbserver is started with --multi, and
diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite/gdb.server/monitor-exit-quit.exp
index c5f8426cb5d..cb90169ef0c 100644
--- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp
+++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {
diff --git a/gdb/testsuite/gdb.server/no-thread-db.exp b/gdb/testsuite/gdb.server/no-thread-db.exp
index e04e43c78a3..9cbe962bc3c 100644
--- a/gdb/testsuite/gdb.server/no-thread-db.exp
+++ b/gdb/testsuite/gdb.server/no-thread-db.exp
@@ -28,7 +28,7 @@ set unresolvable_thread_db_path "/foo/bar"
 require allow_gdbserver_tests
 
 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {
diff --git a/gdb/testsuite/gdb.server/pread-offset-size.exp b/gdb/testsuite/gdb.server/pread-offset-size.exp
index 4362878c8e6..68f938d42c6 100644
--- a/gdb/testsuite/gdb.server/pread-offset-size.exp
+++ b/gdb/testsuite/gdb.server/pread-offset-size.exp
@@ -24,7 +24,7 @@ standard_testfile .S
 
 if { [prepare_for_testing ${testfile}.exp $testfile \
 	$srcfile {debug additional_flags=-nostdlib} ] } {
-    return -1
+    return
 }
 
 clean_restart
diff --git a/gdb/testsuite/gdb.server/remote-read-msgs.exp b/gdb/testsuite/gdb.server/remote-read-msgs.exp
index 86c2d610c00..e9d03388e39 100644
--- a/gdb/testsuite/gdb.server/remote-read-msgs.exp
+++ b/gdb/testsuite/gdb.server/remote-read-msgs.exp
@@ -32,12 +32,12 @@ standard_testfile
 
 if {[build_executable "failed to prepare" $testfile $srcfile \
     {debug build-id}] == -1} {
-    return -1
+    return
 }
 
 # Split out BINFILE.debug.  Remove debug from BINFILE.
 if {[gdb_gnu_strip_debug $binfile] != 0} {
-    return -1
+    return
 }
 
 # Get the '.build-id/xx/xxx...xxx' part of the filename.
diff --git a/gdb/testsuite/gdb.server/run-without-local-binary.exp b/gdb/testsuite/gdb.server/run-without-local-binary.exp
index 3aa9eba2d05..24521f21b0f 100644
--- a/gdb/testsuite/gdb.server/run-without-local-binary.exp
+++ b/gdb/testsuite/gdb.server/run-without-local-binary.exp
@@ -20,7 +20,7 @@ require allow_gdbserver_tests
 standard_testfile normal.c
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]
diff --git a/gdb/testsuite/gdb.server/server-connect.exp b/gdb/testsuite/gdb.server/server-connect.exp
index bb6a5758d35..3c8dd114166 100644
--- a/gdb/testsuite/gdb.server/server-connect.exp
+++ b/gdb/testsuite/gdb.server/server-connect.exp
@@ -28,7 +28,7 @@ require allow_gdbserver_tests
 require {!is_remote target}
 
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an
diff --git a/gdb/testsuite/gdb.server/server-exec-info.exp b/gdb/testsuite/gdb.server/server-exec-info.exp
index 7163785348d..4ef9ede9cec 100644
--- a/gdb/testsuite/gdb.server/server-exec-info.exp
+++ b/gdb/testsuite/gdb.server/server-exec-info.exp
@@ -22,7 +22,7 @@ require allow_gdbserver_tests allow_shlib_tests
 
 standard_testfile server.c
 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an
diff --git a/gdb/testsuite/gdb.server/server-kill-python.exp b/gdb/testsuite/gdb.server/server-kill-python.exp
index 09e4d561bee..7c08090c165 100644
--- a/gdb/testsuite/gdb.server/server-kill-python.exp
+++ b/gdb/testsuite/gdb.server/server-kill-python.exp
@@ -27,7 +27,7 @@ require allow_gdbserver_tests allow_python_tests
 
 if {[build_executable "failed to prepare" ${testfile} \
 	 ${srcfile}] == -1} {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]
diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 9a92ef2a6c7..d4bbb466f04 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -25,7 +25,7 @@ standard_testfile
 require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" ${testfile}] } {
-    return -1
+    return
 }
 
 # Spawn GDBserver, run to main, extract GDBserver's PID and save it in
diff --git a/gdb/testsuite/gdb.server/server-mon.exp b/gdb/testsuite/gdb.server/server-mon.exp
index 8811a0c8afa..ef054059faf 100644
--- a/gdb/testsuite/gdb.server/server-mon.exp
+++ b/gdb/testsuite/gdb.server/server-mon.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Make sure we're disconnected, in case we're testing with an
diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.server/server-pipe.exp
index ca9d9cab8b6..724e5a047b1 100644
--- a/gdb/testsuite/gdb.server/server-pipe.exp
+++ b/gdb/testsuite/gdb.server/server-pipe.exp
@@ -42,7 +42,7 @@ standard_testfile normal.c
 set executable ${testfile}
 
 if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 # Start GDB using remote type TARGET, which should be either "remote"
diff --git a/gdb/testsuite/gdb.server/server-run.exp b/gdb/testsuite/gdb.server/server-run.exp
index 776851b3695..a20ef0a5a1f 100644
--- a/gdb/testsuite/gdb.server/server-run.exp
+++ b/gdb/testsuite/gdb.server/server-run.exp
@@ -24,7 +24,7 @@ standard_testfile server.c
 require allow_gdbserver_tests
 
 if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {
diff --git a/gdb/testsuite/gdb.server/solib-list.exp b/gdb/testsuite/gdb.server/solib-list.exp
index ab0fd1586cb..c529bb6edd0 100644
--- a/gdb/testsuite/gdb.server/solib-list.exp
+++ b/gdb/testsuite/gdb.server/solib-list.exp
@@ -32,7 +32,7 @@ set binlibfile [standard_output_file ${testfile}.so]
 if { [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfile}" "${binlibfile}" {debug}] != ""
      || [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "shlib=${binlibfile} build-id"] != "" } {
     untested "failed to compile"
-    return -1
+    return
 }
 
 set interp_system [section_get ${binfile} .interp]
diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
index 01bf3ef67dc..a7eda3f76f0 100644
--- a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp
@@ -34,7 +34,7 @@ require allow_gdbserver_tests
 
 standard_testfile
 if { [build_executable "failed to prepare" $testfile $srcfile {debug pthreads}] == -1 } {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]
diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
index fec2246b479..700b7022415 100644
--- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
+++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp
@@ -26,7 +26,7 @@ require allow_gdbserver_tests
 
 standard_testfile
 if { [build_executable "failed to prepare" $testfile $srcfile] == -1 } {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]
diff --git a/gdb/testsuite/gdb.server/sysroot.exp b/gdb/testsuite/gdb.server/sysroot.exp
index 634168db469..7e4a796e879 100644
--- a/gdb/testsuite/gdb.server/sysroot.exp
+++ b/gdb/testsuite/gdb.server/sysroot.exp
@@ -24,7 +24,7 @@ require allow_gdbserver_tests
 
 standard_testfile
 if {[build_executable "failed to prepare" $testfile $srcfile "additional_flags=--no-builtin"] == -1} {
-    return -1
+    return
 }
 
 set target_binfile [gdb_remote_download target $binfile]
diff --git a/gdb/testsuite/gdb.server/target-exec-file.exp b/gdb/testsuite/gdb.server/target-exec-file.exp
index 7c204cc9abd..a9e6f801165 100644
--- a/gdb/testsuite/gdb.server/target-exec-file.exp
+++ b/gdb/testsuite/gdb.server/target-exec-file.exp
@@ -26,7 +26,7 @@ require allow_gdbserver_tests !use_gdb_stub
 standard_testfile
 
 if { [build_executable "failed to prepare" $testfile $srcfile debug] } {
-    return -1
+    return
 }
 
 clean_restart
@@ -223,7 +223,7 @@ set res [remote_exec target "touch $target_exec"]
 set status [lindex $res 0]
 if { $status != 0 } {
     fail "touching executable on target"
-    return -1
+    return
 }
 
 # Start the inferior again, we expect to see the symbols being re-read
diff --git a/gdb/testsuite/gdb.server/twice-connect.exp b/gdb/testsuite/gdb.server/twice-connect.exp
index eaf910179f7..45f2eb5aa59 100644
--- a/gdb/testsuite/gdb.server/twice-connect.exp
+++ b/gdb/testsuite/gdb.server/twice-connect.exp
@@ -23,7 +23,7 @@ require allow_gdbserver_tests
 
 if { [build_executable "failed to prepare" $::testfile $::srcfile \
 	  {debug}] } {
-    return -1
+    return
 }
 
 # Don't use $binfile arg, to make sure we use the remote file target:$binfile.
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
index 9478640c40e..15643fb92a7 100644
--- a/gdb/testsuite/gdb.server/wrapper.exp
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -26,7 +26,7 @@ require allow_gdbserver_tests
 if { [istarget *-*-mingw*]
      || [istarget *-*-cygwin*] } {
     unsupported "gdbserver does not support --wrapper on this target (PR server/15967)"
-    return -1
+    return
 }
 
 save_vars { GDBFLAGS } {
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.