[binutils-gdb] GDB: testsuite: server: Don't return value from top-level (manual)

Thiago Bauermann via Gdb-cvs <[email protected]>
Newsgroups gmane.comp.gdb.cvs
Message-ID <[email protected]>
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e4ad9d0bcdc01c93e3f894c5b54f16b77c8a9f44

commit e4ad9d0bcdc01c93e3f894c5b54f16b77c8a9f44
Author: Thiago Jung Bauermann <[email protected]>
Date:   Wed Apr 29 20:04:22 2026 -0300

    GDB: testsuite: server: Don't return value from top-level (manual)
    
    This patch manually changes "return -1" statements that weren't caught
    by the sed command.
    
    These return statements return at top level but inside block such as
    save_vars and with_test_prefix.
    
    I also fixed one case of top-level "return 0".
    
    Approved-By: Tom Tromey <[email protected]>

Diff:
---
 gdb/testsuite/gdb.server/abspath.exp                 | 2 +-
 gdb/testsuite/gdb.server/exit-multiple-threads.exp   | 2 +-
 gdb/testsuite/gdb.server/ext-restart.exp             | 2 +-
 gdb/testsuite/gdb.server/ext-wrapper.exp             | 2 +-
 gdb/testsuite/gdb.server/extended-remote-restart.exp | 2 +-
 gdb/testsuite/gdb.server/multi-ui-errors.exp         | 2 +-
 gdb/testsuite/gdb.server/reconnect-ctrl-c.exp        | 2 +-
 gdb/testsuite/gdb.server/wrapper.exp                 | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/testsuite/gdb.server/abspath.exp b/gdb/testsuite/gdb.server/abspath.exp
index 5bd7f7e842b..7c4d43ff474 100644
--- a/gdb/testsuite/gdb.server/abspath.exp
+++ b/gdb/testsuite/gdb.server/abspath.exp
@@ -38,7 +38,7 @@ save_vars { GDBFLAGS } {
     }
 
     if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-	return -1
+	return
     }
 }
 
diff --git a/gdb/testsuite/gdb.server/exit-multiple-threads.exp b/gdb/testsuite/gdb.server/exit-multiple-threads.exp
index 1b0941eb3c7..c6e19f8dfb4 100644
--- a/gdb/testsuite/gdb.server/exit-multiple-threads.exp
+++ b/gdb/testsuite/gdb.server/exit-multiple-threads.exp
@@ -140,7 +140,7 @@ foreach_with_prefix test { exit signal } {
     set executable "$binfile-${test}"
     if {[build_executable "failed to prepare" $executable $srcfile \
 	     [list debug pthreads additional_flags=-D${def}]]} {
-	return -1
+	return
     }
 
     set target_executable [gdb_remote_download target $executable]
diff --git a/gdb/testsuite/gdb.server/ext-restart.exp b/gdb/testsuite/gdb.server/ext-restart.exp
index 39d42d7a441..031aaeb5db8 100644
--- a/gdb/testsuite/gdb.server/ext-restart.exp
+++ b/gdb/testsuite/gdb.server/ext-restart.exp
@@ -31,7 +31,7 @@ save_vars { GDBFLAGS } {
     }
 
     if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-	return -1
+	return
     }
 }
 
diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp
index 912a8ce3770..757127b1548 100644
--- a/gdb/testsuite/gdb.server/ext-wrapper.exp
+++ b/gdb/testsuite/gdb.server/ext-wrapper.exp
@@ -33,7 +33,7 @@ save_vars { GDBFLAGS } {
     }
 
     if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-	return -1
+	return
     }
 }
 
diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp
index f10d2f374c0..a592dba79ed 100644
--- a/gdb/testsuite/gdb.server/extended-remote-restart.exp
+++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp
@@ -42,7 +42,7 @@ require {is_any_target "*-*-linux*" "*-*-openbsd*"}
 set gdbserver_reconnect_p 1
 if { [info proc gdb_reconnect] == "" } {
     unsupported "requires gdbserver reconnect"
-    return 0
+    return
 }
 
 standard_testfile
diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/gdb.server/multi-ui-errors.exp
index c17de8bf2e4..dde936c1a45 100644
--- a/gdb/testsuite/gdb.server/multi-ui-errors.exp
+++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp
@@ -37,7 +37,7 @@ save_vars { GDBFLAGS } {
     }
 
     if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
-	return -1
+	return
     }
 }
 
diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
index 63502887bf5..c0e129db76d 100644
--- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
+++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
@@ -33,7 +33,7 @@ save_vars { GDBFLAGS } {
     }
 
     if {[prepare_for_testing "failed to prepare" $testfile $srcfile]} {
-	return -1
+	return
     }
 }
 
diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
index 15643fb92a7..40c29c441fa 100644
--- a/gdb/testsuite/gdb.server/wrapper.exp
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -37,7 +37,7 @@ save_vars { GDBFLAGS } {
     }
 
     if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-	return -1
+	return
     }
 }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.