Re: [PATCH] guile: Type-check the argument to 'history-append!'

[email protected] (Ludovic Courtès) Fri, 06 Jun 2014 00:06:07 +0200

Newsgroups	gmane.comp.gdb.devel
Message-ID	<[email protected]>

Doug Evans <[email protected]> skribis:

> On Thu, Jun 5, 2014 at 5:50 AM, Ludovic Courtès <[email protected]> wrote:
>> The patch below add a missing type check in ‘history-append!’ (I’m guilty.)
>>
>> OK to push?
>>
>> Ludo’.
>>
>> gdb/
>> 2014-06-05  Ludovic Courtès  <[email protected]>
>>
>>         * guile/scm-value.c (gdbscm_history_append_x): Use
>>         'vlscm_get_value_smob_arg_unsafe' instead of
>>         'vlscm_scm_to_value'.
>>
>> gdb/testsuite/
>> 2014-06-05  Ludovic Courtès  <[email protected]>
>>
>>         * gdb.guile/scm-value.exp (test_value_in_inferior): Add test
>>         "history-append! type error".
>
> LGTM.

Thanks, pushed.

Ludo’.